Bug 162143

Summary: 'offset' is used uninitialized in this function
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: gtkhtml3Assignee: Dave Malcolm <dmalcolm>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-12-13 04:15:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 150221    

Description David Binderman 2005-06-30 10:08:15 UTC 
Description of problem:

I just tried to compile package gtkhtml3-3.6.2-1 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

gtkhtml.c:3285: warning: 'offset' is used uninitialized in this function

The source code is

        D_IM (printf ("IM gtk_html_im_retrieve_surrounding_cb\n");)
        gtk_im_context_set_surrounding (context, get_surrounding_text
(html->engine, &offset), -1, offset);

I agree with the compiler. This code would benefit from rework, because
there is no defined ordering on the evaluation of function parameters.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Dave Malcolm 2005-08-18 03:30:41 UTC 
Thanks for this report.  I'll try to get this fixed upstream.
Comment 2 Dave Malcolm 2005-08-18 21:04:30 UTC 
I've sent a patch upstream for this
Comment 3 Dave Malcolm 2005-12-13 04:15:24 UTC 
(this is now fixed in upstream CVS, and in the current rawhide gtkhtml3 tarball)