Bug 1622073

Description of problem:

After upgrade from Fedora 25 to 28 using dnf, Owncloud started to return "HTTP ERROR 500" after the login screen (for all users, including admin).

Looks like this is simple to fix, please check the Additional Info section for it.

Version-Release number of selected component (if applicable):

owncloud-9.1.5-3.fc28.noarch

How reproducible:

Always

Steps to Reproduce:
1. Upgrade from Fedora 26 to Fedora 28
2. Open owncloud in you browser: http://FQDN/owncloud
3. Enter user / password

Actual results:

Login works but owncloud returns HTTP 500 error: 

Got from SERVER_FQDN/owncloud/index.php/login: “This page isn’t working - HTTP ERROR 500”

Expected results:

Owncloud be able load the content and I access the files and documents.

Additional info:

Was using Fedora 26 and upgraded to Fedora 28 through dnf.

FROM:
# dnf history info 15 | grep -i owncloud
    Upgraded   owncloud-9.1.5-1.fc26.noarch                                      @fedora/26
    Upgraded   owncloud-httpd-9.1.5-1.fc26.noarch                                @fedora/26
    Upgraded   owncloud-mysql-9.1.5-1.fc26.noarch                                @fedora/26
    Upgraded   php-owncloud-tarstreamer-0.1.0-2.fc26.noarch                      @fedora/26

TO:

# rpm -qa | grep -i owncloud
owncloud-mysql-9.1.5-3.fc28.noarch
php-owncloud-tarstreamer-0.1.0-4.fc28.noarch
owncloud-9.1.5-3.fc28.noarch
owncloud-httpd-9.1.5-3.fc28.noarch

Looking PHP logs and files I found the following errors:

#pwd
/var/log/php-fpm

[...]
[23-Aug-2018 21:34:46 UTC] PHP Fatal error: Declaration of OC\Files\Storage\Local::copyFromStorage(OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath) must be compatible with OC\Files\Storage\Common::copyFromStorage(OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime = false) in /usr/share/owncloud/lib/private/Files/Storage/Local.php on line 42
[23-Aug-2018 21:37:08 UTC] PHP Fatal error: Declaration of OC\Files\Storage\Local::copyFromStorage(OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath) must be compatible with OC\Files\Storage\Common::copyFromStorage(OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime = false) in /usr/share/owncloud/lib/private/Files/Storage/Local.php on line 42
[...]

I found a solution in owncloud's github and looks like there is already a patch for it: https://github.com/nextcloud/server/pull/5072/files

So I went to my file: /usr/share/owncloud/lib/private/Files/Storage/Local.php: Line 412

Changed

- public function copyFromStorage(\OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath) {
+ public function copyFromStorage(\OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime = false) {

Restarted the services and it worked like a charm. I was also checking to see if it was not a problem with the installation script. But I found that the Fedora's package does not have this patch

# dnf download owncloud-9.1.5-3.fc28.noarch
# rpm2cpio ./owncloud-9.1.5-3.fc28.noarch.rpm | cpio -idmv
# pwd
# cd /root/Test/usr/share/owncloud/lib/private/Files/Storage
# cat -n Local.php | grep 412
   412		public function copyFromStorage(\OCP\Files\Storage $sourceStorage, $sourceInternalPath, $targetInternalPath) {

So the patch was not applied. I think this is something really simple to be backported. Not sure if all upgrades / installation causes the same because I am using a local storage and this function seems to be related to it. Probably who is using external storage does not face the same.