Bug 1622439

Summary: master-api/controller/etcd should be in system-node-critical priorityClassName
Product: OpenShift Container Platform Reporter: DeShuai Ma <dma>
Component: NodeAssignee: Avesh Agarwal <avagarwa>
Status: CLOSED ERRATA QA Contact: DeShuai Ma <dma>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.11.0CC: aos-bugs, jokerman, mmccomas, sjenning
Target Milestone: ---   
Target Release: 3.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-11 07:25:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description DeShuai Ma 2018-08-27 08:22:52 UTC 
Description of problem:
As comment https://trello.com/c/tK1L0HwE/905-3-scheduler-system-critical-and-node-critical-priority-classes-should-be-restricted-to-few-namespaces#comment-5b7c49f169e59f07c321325a, master-api/controller/etcd should in system-node-critical priorityClassName, But now it's in system-cluster-critical

Version-Release number of selected component (if applicable):
openshift v3.11.0-0.22.0
kubernetes v1.11.0+d4cacc0

How reproducible:
100%

Steps to Reproduce:
1. Check the priorityClassName of master api/controller/etcd pod
oc get po -n kube-system -o yaml|grep priorityClassName


Actual results:
1. the priorityClassName of master api/controller/etcd is system-cluster-critical
[root@qe-dma-master-etcd-1 ~]# oc get po -n kube-system
NAME                                      READY     STATUS    RESTARTS   AGE
master-api-qe-dma-master-etcd-1           1/1       Running   0          5h
master-controllers-qe-dma-master-etcd-1   1/1       Running   0          5h
master-etcd-qe-dma-master-etcd-1          1/1       Running   0          5h
[root@qe-dma-master-etcd-1 ~]# oc get po -n kube-system -o yaml|grep priorityClassName
    priorityClassName: system-cluster-critical
    priorityClassName: system-cluster-critical
    priorityClassName: system-cluster-critical


Expected results:
1. The priorityClassName api/controller/etcd should be system-node-critical

Additional info:
Comment 1 Avesh Agarwal 2018-08-28 16:19:48 UTC 
https://github.com/openshift/openshift-ansible/pull/9801
Comment 2 Avesh Agarwal 2018-08-30 14:56:12 UTC 
(In reply to Avesh Agarwal from comment #1)
> https://github.com/openshift/openshift-ansible/pull/9801

PR is merged. Moving it to Modified.
Comment 4 DeShuai Ma 2018-09-06 02:39:53 UTC 
Verify on 3.11.0-0.28.0

[root@ip-172-18-6-161 ~]# oc get po -n kube-system -o yaml|grep priorityClassName
    priorityClassName: system-node-critical
    priorityClassName: system-node-critical
    priorityClassName: system-node-critical
[root@ip-172-18-6-161 ~]# 
[root@ip-172-18-6-161 ~]# oc version
oc v3.11.0-0.28.0
kubernetes v1.11.0+d4cacc0
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://ip-172-18-6-161.ec2.internal:8443
openshift v3.11.0-0.28.0
kubernetes v1.11.0+d4cacc0
Comment 6 errata-xmlrpc 2018-10-11 07:25:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2652