Bug 1622612

Summary:	The specified reference is incorrect after template change
Product:	Red Hat OpenStack	Reporter:	Andreas Karis <akaris>
Component:	openstack-heat	Assignee:	Zane Bitter <zbitter>
Status:	CLOSED ERRATA	QA Contact:	Ronnie Rasouli <rrasouli>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	10.0 (Newton)	CC:	bnemec, emacchi, hchatter, jamsmith, mburns, mcornea, pcaruana, ramishra, sbaker, shardy, srevivo, therve, zbitter
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	10.0 (Newton)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-heat-7.0.6-5.el7ost	Doc Type:	Bug Fix
Doc Text:	With this update, Heat updates resource definitions incrementally during the update of a non-convergence stack, which allows Heat to make changes to the stack after a failed stack update. Now, if an update fails, the stored template contains only valid references. Prior to this update, Heat did not update resource definitions incrementally. If a stack update failed after updating a resource and then deleting a resource that the updated resource previously depended on, the stored template could contain a reference to a non-existent resource, leaving Heat unable to make changes to the stack.	Story Points:	---
Clone Of:
Clones:	1633003 1633004 1633005 1633007 (view as bug list)		Environment:
Last Closed:	2019-01-16 17:10:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1633003, 1633004, 1633005, 1633007

Description Andreas Karis 2018-08-27 15:27:24 UTC

Description of problem:
After template change, tripleo complains with the following during the ExtraConfigPost stage:
~~~
2018-08-27 08:49:12Z [overcloud-AllNodesDeploySteps-agq6y2otdmnr]: UPDATE_FAILED  resources.ComputeExtraConfigPost: The specified reference "Openshiftssh" (in ExtraDeployments-5.Properties.config) is incorrect.
2018-08-27 08:49:13Z [overcloud.AllNodesDeploySteps]: UPDATE_FAILED  resources.AllNodesDeploySteps: resources.ComputeExtraConfigPost: The specified reference "Openshiftssh" (in ExtraDeployments-5.Properties.config) is incorrect.
2018-08-27 08:49:13Z [overcloud]: UPDATE_FAILED  resources.AllNodesDeploySteps: resources.ComputeExtraConfigPost: The specified reference "Openshiftssh" (in ExtraDeployments-5.Properties.config) is incorrect.
~~~

Version-Release number of selected component (if applicable):
Old RPMs, we unfortunately cannot update:
~~~
[akaris@collab-shell 02157826]$ grep tripleo (...)/installed-rpms 
openstack-tripleo-0.0.8-0.2.4de13b3git.el7ost.noarch        Thu Apr 27 13:46:23 2017
openstack-tripleo-common-5.4.1-1.el7ost.noarch              Thu Apr 27 13:47:02 2017
openstack-tripleo-heat-templates-5.2.0-3.el7ost.noarch      Thu Apr 27 13:46:30 2017
openstack-tripleo-image-elements-5.2.0-1.el7ost.noarch      Thu Apr 27 13:46:34 2017
openstack-tripleo-puppet-elements-5.2.0-2.el7ost.noarch     Thu Apr 27 13:47:02 2017
openstack-tripleo-ui-1.1.0-1.el7ost.noarch                  Thu Apr 27 14:36:50 2017
openstack-tripleo-validations-5.1.1-1.el7ost.noarch         Thu Apr 27 14:38:11 2017
puppet-tripleo-5.5.0-4.el7ost.noarch                        Thu Apr 27 13:46:58 2017
python-tripleoclient-5.4.1-1.el7ost.noarch                  Thu Apr 27 13:47:03 2017
~~~

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 26 Zane Bitter 2018-08-31 21:02:44 UTC

I found the cause: I totally misremembered how this works. We do update the template in the DB, but only for the *backup* stack when we are updating a resource in-place. However when deleting a resource, we remove it from the main stack's template. This combination is invalid, since it will lead to this situation when a resource previously depended on one that is being deleted, and the stack update fails for any reason after the deletion has taken place.

Comment 34 Marius Cornea 2018-12-06 22:42:34 UTC

openstack-heat-engine-7.0.6-5.el7ost.noarch

Comment 37 errata-xmlrpc 2019-01-16 17:10:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0076