Bug 1622685
| Summary: | Review Request: nodejs-zeropad - Zeropad your integers with optional n-length padding | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Rosser <rosser.bjr> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-09-21 05:23:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1622684 | ||
| Bug Blocks: | 1622686 | ||
|
Description
Ben Rosser
2018-08-27 18:17:03 UTC
Add dependency on nodejs-negative-zero. Tests fail:
4 passing (9ms)
3 failing
1) zeropad throws when num is NaN:
TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is ambiguous. The error message "zeropad requires a number or string" is identical to the message.
at expectsError (assert.js:615:15)
at Function.throws (assert.js:676:3)
at Context.<anonymous> (test.js:32:16)
2) zeropad throws when length is NaN:
TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is ambiguous. The error message "zeropad requires a positive integer for length" is identical to the message.
at expectsError (assert.js:615:15)
at Function.throws (assert.js:676:3)
at Context.<anonymous> (test.js:38:16)
3) zeropad throws on negative length:
TypeError [ERR_AMBIGUOUS_ARGUMENT]: The "error/message" argument is ambiguous. The error message "zeropad requires a positive integer for length" is identical to the message.
at expectsError (assert.js:615:15)
at Function.throws (assert.js:676:3)
at Context.<anonymous> (test.js:44:16)
Node v10 has some additional assert sanity checks: if the thrown error message text equals the assert function call's descriptive message text argument, it reports this error. In order to fix this, you thus can change the message:
# Add tests to npm archive.
# https://github.com/radiovisual/zeropad/pull/1
Source1: https://raw.githubusercontent.com/radiovisual/zeropad/3bd15b69384cc74d55ac2c4c870728b74d1ff9a9/test.js
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Package approved. Please fix the tests above before import.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-zeropad Thanks for fixing the tests on node 10! nodejs-zeropad-1.1.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-43c321e6ab nodejs-zeropad-1.1.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-43c321e6ab nodejs-zeropad-1.1.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |