Bug 1623459

Summary: Release patched a2x for Fedora 28
Product: [Fedora] Fedora Reporter: Jan Staněk <jstanek>
Component: asciidocAssignee: Josef Ridky <jridky>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 28CC: chrisw, fziglio, jridky, nphilipp, sochotni, tmz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: asciidoc-8.6.10-0.8.20180605git986f99d.fc29 asciidoc-8.6.10-0.8.20180605git986f99d.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-12-18 03:05:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jan Staněk 2018-08-29 12:21:42 UTC
Description of problem:
In current Fedora 28, asciidoc ships with broken a2x binary (calling non-existent decode method on string object). As far as I can tell, this issue is fixed in F29+ with the asciidoc-python3-a2x-decode-fix.patch.

Version-Release number of selected component (if applicable):
asciidoc-8.6.10-0.1.20180605git986f99d.fc28

How reproducible:
Try to convert document to xhtml:

$ a2x -f xhtml -D doc/xhtml doc/source.txt

Actual results:
Traceback (most recent call last):
  File "/usr/bin/a2x", line 952, in <module>
    a2x.execute()
  File "/usr/bin/a2x", line 373, in execute
    self.__getattribute__('to_'+self.format)()
  File "/usr/bin/a2x", line 650, in to_xhtml
    self.copy_resources(xhtml_file, src_dir, self.destination_dir)
  File "/usr/bin/a2x", line 582, in copy_resources
    lambda attrs: attrs.get('type') == 'text/css')
  File "/usr/bin/a2x", line 263, in find_resources
    parser.feed(contents.decode(encoding))
AttributeError: 'str' object has no attribute 'decode'

Expected results:
No error, document is converted.

Comment 1 Fedora Update System 2018-12-03 14:38:27 UTC
asciidoc-8.6.10-0.8.20180605git986f99d.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-46a87cbed7

Comment 2 Fedora Update System 2018-12-03 14:38:37 UTC
asciidoc-8.6.10-0.8.20180605git986f99d.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f6de12c954

Comment 3 Fedora Update System 2018-12-04 03:38:09 UTC
asciidoc-8.6.10-0.8.20180605git986f99d.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f6de12c954

Comment 4 Fedora Update System 2018-12-04 05:02:18 UTC
asciidoc-8.6.10-0.8.20180605git986f99d.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-46a87cbed7

Comment 5 Fedora Update System 2018-12-18 03:05:09 UTC
asciidoc-8.6.10-0.8.20180605git986f99d.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2019-01-04 03:23:30 UTC
asciidoc-8.6.10-0.8.20180605git986f99d.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.