Bug 1623554

Summary:	[OSP10] RX/TX Queue Size is missing THT parameter
Product:	Red Hat OpenStack	Reporter:	Lee Yarwood <lyarwood>
Component:	openstack-tripleo-heat-templates	Assignee:	Ollie Walsh <owalsh>
Status:	CLOSED ERRATA	QA Contact:	Joe H. Rahme <jhakimra>
Severity:	high	Docs Contact:
Priority:	high
Version:	10.0 (Newton)	CC:	agurenko, cfontain, eelena, emacchi, fbaudin, jamsmith, jhakimra, jraju, lyarwood, mbabushk, mburns, mschuppe, oblaut, owalsh, skramaja, supadhya, yrachman, zgreenbe
Target Milestone:	z10	Keywords:	Triaged, ZStream
Target Release:	10.0 (Newton)
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-5.3.10-18.el7ost	Doc Type:	Bug Fix
Doc Text:	This update adds a TripleO heat template parameter as an option for setting RX/TX queue size. Prior to this update, users could set RX/TX queue size with `nova::compute::libvirt::rx_queue_size/nova::compute::libvirt::tx_queue_size`. However, there was no dedicated TripleO heat template parameter. With this update, users can set the RX/TX queue size either on a global level using: ``` parameter_defaults: NovaLibvirtRxQueueSize: 1024 NovaLibvirtTxQueueSize: 1024 ``` or overwrite the hieradata via [ROLE]ExtraConfig, which then can be used to configure a subset of compute nodes for which a dedicated role was created: ``` parameter_defaults: NovaComputeExtraConfig: nova::compute::libvirt::rx_queue_size: 1024 nova::compute::libvirt::tx_queue_size: 1024 ``` Note: The possibilities described above are mutually exclusive.	Story Points:	---
Clone Of:	1623553	Environment:
Last Closed:	2019-01-16 17:09:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1617927, 1619104, 1623553
Bug Blocks:

Description Lee Yarwood 2018-08-29 15:24:28 UTC

+++ This bug was initially created as a clone of Bug #1623553 +++

+++ This bug was initially created as a clone of Bug #1619104 +++

+++ This bug was initially created as a clone of Bug #1617927 +++

Description of problem:
RX/TX Queue size implemented in RHOSP 14 according to the following BZ [1] [2], missing THT parameters.

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1553088
[2] - https://bugzilla.redhat.com/show_bug.cgi?id=1512941

THT parameters should configure rx_queue_size and tx_queue_size in nova.conf
[libvirt]
rx_queue_size=1024
tx_queue_size=1024

--- Additional comment from Eric Elena on 2018-08-16 04:18:31 EDT ---

Please note that as per [0] you can use the following snippet:

parameter_defaults:
  ComputeExtraConfig:
    nova::compute::libvirt::rx_queue_size: 1024
    nova::compute::libvirt::tx_queue_size: 1024

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1571745

--- Additional comment from Martin Schuppert on 2018-08-22 05:58:49 EDT ---

RX/TX queue size can be set on a role base like:

parameter_defaults:
  ComputeParameters:
    NovaLibvirtRxQueueSize: 1024
    NovaLibvirtTxQueueSize: 1024

[root@compute-0 ~]# egrep "^rx|^tx" /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf 
rx_queue_size=1024
tx_queue_size=1024

Comment 12 Joe H. Rahme 2019-01-09 12:54:10 UTC

Verification steps

Deployed using the following params:

	parameter_defaults:
	  NovaLibvirtRxQueueSize: 1024
	  NovaLibvirtTxQueueSize: 1024
	
After deployment we can see the changes reflected in nova.conf:

	[heat-admin@compute-0 ~]$ sudo egrep '(rx|tx)' /etc/nova/nova.conf
	# Configure virtio rx queue size.
	#rx_queue_size=<None>
	rx_queue_size=1024
	# Configure virtio tx queue size.
	#tx_queue_size=<None>
	tx_queue_size=1024
	

Package tested:

	[stack@undercloud-0 ~]$ yum info openstack-tripleo-heat-templates                                                                                                            
	Loaded plugins: search-disabled-repos
	Installed Packages
	Name        : openstack-tripleo-heat-templates
	Arch        : noarch
	Version     : 5.3.10
	Release     : 23.el7ost
	Size        : 1.5 M
	Repo        : installed
	From repo   : rhelosp-10.0-puddle
	Summary     : Heat templates for TripleO
	URL         : https://wiki.openstack.org/wiki/TripleO
	License     : ASL 2.0
	Description : OpenStack TripleO Heat Templates is a collection of templates and tools for
	            : building Heat Templates to do deployments of OpenStack.

Comment 14 errata-xmlrpc 2019-01-16 17:09:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0055