Bug 162369

Summary:	undefined code
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	libdv	Assignee:	Warren Togami <wtogami>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-07-04 02:52:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-07-03 12:00:10 UTC

Description of problem:

I just tried to compile package libdv-0.103-4 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

encode.c:1754: warning: operation on 'i' may be undefined

The source code is

	dv_enc->img_y[i] = CLAMP(dv_enc->img_y[i++], -224, 214)

I agree with the compiler. Suggest rework code to avoid reading from
variable "i" at the same time as incrementing it.

Maybe 

	(dv_enc->img_y[i] = CLAMP( dv_enc->img_y[i], -224, 214)), ++i

is better code.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Warren Togami 2005-07-04 02:52:26 UTC

Could you please submit this to the upstream project?  It is not worth the
effort to fix trivial issues like this that seemingly have no security or even
functional impact.

Comment 2 David Binderman 2005-07-04 10:53:04 UTC

>Could you please submit this to the upstream project?  

Would like to be able to, but sorry I am unable.

Suggest either we forget about this trivial bug, or we can 
leave it hanging for someone else to pick up.