Bug 1623848

A scratch build of perl-Pegex-0.65 is done at:

https://koji.fedoraproject.org/koji/taskinfo?taskID=29392324


I am not sure if this lines have to be included for perl_bootstrap

# Remove bundled modules
rm -r ./inc
sed -i -e '/^inc\//d' MANIFEST


I simple removed this lines from the spec file so that package will build out of the box.

As next step I will upload the new source file if the perl bootstrap is not broken.

The ./inc removal was there for unbundling TestML. Not for bootstrapping. If you keep bundling TestML, you would have to build-require all TestML dependencies and actually resolve any issues caused by the bundled code. I think bundling TestML will not break bootstrapping.

I have done a new rawhide scratch at:

https://koji.fedoraproject.org/koji/taskinfo?taskID=29394664

To not bundle TestML I added again in spec the line:

sed -i -e '/^inc\//d' MANIFES


If I would remove the directory ./inc then the tests:
 t/compiler-checks.t t/compiler-equivalence.t t/compiler.t t/error.t t/optimize.t t/tree-pegex.t t/tree.t

also would have to be removed because they use the script 'inc/bin/testml-cpan'.


It looks like that is sufficient to not bundle TestML. (I hope so, because I seen no wrong provides or files includes.)

(In reply to Gerd Pokorra from comment #3)
> To not bundle TestML I added again in spec the line:
> 
> sed -i -e '/^inc\//d' MANIFES
>
This only removes them from a index. The real removal is implemented by the "rm" command.
 
> If I would remove the directory ./inc then the tests:
>  t/compiler-checks.t t/compiler-equivalence.t t/compiler.t t/error.t
> t/optimize.t t/tree-pegex.t t/tree.t
> 
> also would have to be removed because they use the script
> 'inc/bin/testml-cpan'.
>
Pegex-0.65 seems bundling not-yet-released TestML-0.54_*. The stable TestML-0.54 was moved to TestML1 (not yet packaged in Fedora). That makes Pegex-0.65 incompatible with TestML-0.54.
 
> It looks like that is sufficient to not bundle TestML. (I hope so, because I
> seen no wrong provides or files includes.)

It's about bundling build-time dependencies. Not a run-time.

Feel free to keep the bundled TestML in this new Pegex release. It's only a build-time think. Once Upstream releases a new stable TestML, you can try to unbundle it.

Don't forget to list ./inc files' dependencies as BuildRequires of perl-Pegex.

(In reply to Petr Pisar from comment #4)

What do you mean with:

> Don't forget to list ./inc files' dependencies as BuildRequires of
> perl-Pegex.

I do not know how to handle this.

E.g. inc/lib/TestML/Run.pm:11 uses JSON::PP, thus "BuildRequies: perl(JSON::PP)" should be added to perl-Pegex.spec. There can more of these new dependencies.

perl-Pegex-0.65-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d2cff1e5c0

Should Pegex-0.65 also be build for F28?

perl-Pegex-0.65-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d2cff1e5c0

You need to read to code changes and check whether it's compatible or not. Based on the results, you can decide if it is possible to build Pegex-0.65 for F28.

perl-Pegex-0.65-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.