Bug 1623901
| Summary: | s390: The cpi service in systemd is not enabled by defaults | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Borntraeger <borntraeger> | ||||
| Component: | fedora-release | Assignee: | Mohan Boddu <mboddu> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 28 | CC: | awilliam, borntraeger, dan, dennis, jdisnard, jkeating, kellin, kevin, mboddu, pbrobinson, sgallagh, zbyszek | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | s390x | ||||||
| OS: | Linux | ||||||
| Whiteboard: | AcceptedFreezeException | ||||||
| Fixed In Version: | fedora-release-29-0.16 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-09-18 06:21:02 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1517012 | ||||||
| Attachments: |
|
||||||
|
Description
Christian Borntraeger
2018-08-30 12:10:01 UTC
Fee free to do a PR here to enable it: https://src.fedoraproject.org/rpms/fedora-release, it can be then reviewed and merged (you'll want both f29 and master PRs) Please see https://fedoraproject.org/wiki/Packaging:DefaultServices for the policy on systemd units. Specifically, please read the "Enabling Services by Default" section and tell us whether it meets all of the conditions there. If not, a request has to go to FESCo for determination. Created attachment 1479809 [details] patch for fedora-release As I am still struggling to get the proper fedora acoount/git setup ready, here is the patch for https://src.fedoraproject.org/rpms/fedora-release Regarding the service itself: This is mostly a one-shot service but it can also be triggered by a udev rule. cpi.service - does not alter other services - does not require pre-configuration to start - does not exit with an error, even if the hardware interface is not there As an additional remark: the cpi.service is the replacement of the older cpi.initd init script (e.g. see https://src.fedoraproject.org/rpms/s390utils/blob/f23/f/cpi.initd ) that one was enabled by default as well. I can help with that. We also need "device_cio_free" service to be enabled by default (until fully switched to zdev). PR reported as https://src.fedoraproject.org/rpms/fedora-release/pull-request/22 (and pull-request/23 for f29) This was merged upstream but has yet to make it into the fedora-release RPM. Mohan, could you look into this, please? Proposed as a Freeze Exception for 29-beta by Fedora user sgallagh using the blocker tracking app because: Default service configuration is not changeable post-release, so this makes it a good candidate for a Freeze Exception. fedora-release-29-0.16 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-83b00773a8 I'm +1 FE for this, seems useful for s390 and shouldn't be able to hurt anything else. +1 FE Counting Stephen, that's +3. fedora-release-29-0.16 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-83b00773a8 fedora-release-29-0.16 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. The version that installs from https://download.fedoraproject.org/pub/fedora-secondary/development/29/Server/s390x/os (e.g. via virt-install) still contains the old packages. So I still have the old default after a fresh install (the package is from August). Will the install files be updated as well? Otherwise the admin has to know that it has to do an "systemctl preset cpi" after "dnf update" I can confirm that everything works after "dnf update" + "systemctl preset cpi" Based on comment #14 the updated fedora-release will appear in tomorrow's nightly compose (it probably missed today's). But you can verify it with the Beta RC3 (Fedora-29-20180916.0) from https://kojipkgs.fedoraproject.org/compose/29/Fedora-29-20180916.0/compose/Everything/s390x/os/ (the updated fedora-release is there). > I still have the old default after a fresh install (the package is from August).
Presets are applied only when the package is initially installed. So after the fedora-release package is updated, *new* installs will have the service enabled. If *old* installs are supposed to be updated automatically, this would have to be done by some custom scriptlet in the package (a %trigger scriptlet). s390utils don't contain any such scriptlets afaics.
(In reply to Dan Horák from comment #16) > ut you can verify it with the Beta RC3 (Fedora-29-20180916.0) from > https://kojipkgs.fedoraproject.org/compose/29/Fedora-29-20180916.0/compose/ > Everything/s390x/os/ (the updated fedora-release is there). Yes. I can confirm that this has the fix right from the start. Cool. If handling the update case is desired, maybe open a new bug for that? Thanks! as long as the release version of the f29 installer already contains the fix, we are probably good and do not need to worry about update. |