Bug 1624041

Summary: [CRI-O] Fix should support inline execution and attach e2e test
Product: OpenShift Container Platform Reporter: Mrunal Patel <mpatel>
Component: NodeAssignee: Peter Hunt <pehunt>
Status: CLOSED WONTFIX QA Contact: weiwei jiang <wjiang>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.11.0CC: aos-bugs, ccoleman, dwalsh, gscrivan, jokerman, mmccomas, nagrawal, vlaad, wjiang
Target Milestone: ---   
Target Release: 4.1.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-27 19:40:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mrunal Patel 2018-08-30 17:44:53 UTC
Description of problem:
"should support inline execution and attach" e2e test should be fixed to remove docker specific assumptions so that it works with cri-o.



How reproducible:
Always


Steps to Reproduce:
1. run the test


Actual results:
The test hangs.


Expected results:
The test doesn't hang.

Comment 2 Clayton Coleman 2019-01-05 21:13:07 UTC
This is still disabled in our test suite.  It needs to be reenabled for 4.0

Comment 3 Clayton Coleman 2019-02-25 03:07:59 UTC
https://github.com/openshift/origin/pull/22143 is testing reenabling

Comment 5 Giuseppe Scrivano 2019-03-07 11:52:50 UTC
proposed fix here: https://github.com/kubernetes-sigs/cri-o/pull/2106

@Mrunal, what do you think of it?

Comment 6 Daniel Walsh 2019-03-14 11:38:06 UTC
Since the proposed patch was closed, where do we go now?

Comment 7 Mrunal Patel 2019-03-15 00:59:24 UTC
I have opened a new PR with the fix that mimics docker behavior - https://github.com/kubernetes-sigs/cri-o/pull/2129.

Comment 8 Mrunal Patel 2019-03-21 21:20:31 UTC
Fixed in CRI-O 1.12.9 and 1.13.3.

Comment 11 weiwei jiang 2019-04-12 08:32:05 UTC
Checked with following version, and still hang there.

➜  ~ oc version 
Client Version: version.Info{Major:"4", Minor:"1+", GitVersion:"v4.1.0", GitCommit:"7ad663e77", GitTreeState:"", BuildDate:"2019-04-11T22:43:58Z", GoVersion:"", Compiler:"", Platform:""}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.4+af45cda", GitCommit:"af45cda", GitTreeState:"clean", BuildDate:"2019-04-10T12:16:17Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
➜  ~ oc get nodes -o wide 
NAME                                              STATUS   ROLES    AGE     VERSION             INTERNAL-IP    EXTERNAL-IP   OS-IMAGE                                                   KERNEL-VERSION         CONTAINER-RUNTIME
ip-10-0-133-60.ap-northeast-1.compute.internal    Ready    master   4h40m   v1.13.4+1ad602308   10.0.133.60    <none>        Red Hat Enterprise Linux CoreOS 410.8.20190408.1 (Ootpa)   4.18.0-80.el8.x86_64   cri-o://1.13.4-3.rhaos4.1.git30006b3.el8
ip-10-0-143-209.ap-northeast-1.compute.internal   Ready    worker   4h34m   v1.13.4+1ad602308   10.0.143.209   <none>        Red Hat Enterprise Linux CoreOS 410.8.20190408.1 (Ootpa)   4.18.0-80.el8.x86_64   cri-o://1.13.4-3.rhaos4.1.git30006b3.el8
ip-10-0-157-224.ap-northeast-1.compute.internal   Ready    master   4h40m   v1.13.4+1ad602308   10.0.157.224   <none>        Red Hat Enterprise Linux CoreOS 410.8.20190408.1 (Ootpa)   4.18.0-80.el8.x86_64   cri-o://1.13.4-3.rhaos4.1.git30006b3.el8
ip-10-0-158-60.ap-northeast-1.compute.internal    Ready    worker   4h34m   v1.13.4+1ad602308   10.0.158.60    <none>        Red Hat Enterprise Linux CoreOS 410.8.20190408.1 (Ootpa)   4.18.0-80.el8.x86_64   cri-o://1.13.4-3.rhaos4.1.git30006b3.el8
ip-10-0-173-98.ap-northeast-1.compute.internal    Ready    worker   4h34m   v1.13.4+1ad602308   10.0.173.98    <none>        Red Hat Enterprise Linux CoreOS 410.8.20190408.1 (Ootpa)   4.18.0-80.el8.x86_64   cri-o://1.13.4-3.rhaos4.1.git30006b3.el8
ip-10-0-175-187.ap-northeast-1.compute.internal   Ready    master   4h40m   v1.13.4+1ad602308   10.0.175.187   <none>        Red Hat Enterprise Linux CoreOS 410.8.20190408.1 (Ootpa)   4.18.0-80.el8.x86_64   cri-o://1.13.4-3.rhaos4.1.git30006b3.el8


➜  ~ timeout 100  oc run run-test-3 --image=busybox:1.29 --restart=OnFailure --attach=true --leave-stdin-open=true --stdin -- sh -c "cat && echo 'stdin closed'"
kubectl run --generator=job/v1 is DEPRECATED and will be removed in a future version. Use kubectl run --generator=run-pod/v1 or kubectl create instead.
If you don't see a command prompt, try pressing enter.
➜  ~ timeout 100  oc run run-test-3 --generator=run-pod/v1 --image=busybox:1.29 --restart=OnFailure --attach=true --leave-stdin-open=true --stdin -- sh -c "cat && echo 'stdin closed'"
If you don't see a command prompt, try pressing enter.

Comment 14 Peter Hunt 2020-05-13 18:21:14 UTC
This test is fixed in 4.x series, which I believe sufficient to close this. We've been running the test and passing for the past year+, so I believe it is solved.

Weiwei, can you check again whether it's passing?

Comment 17 weiwei jiang 2020-05-14 05:02:05 UTC
Moved to verified.

[root@ip-10-0-167-30 ~]# echo "test"|oc run run-test-3 --image=busybox:1.29 --restart=OnFailure --attach=true --leave-stdin-open=true --stdin -- sh -c "cat && echo 'stdin closed'"
kubectl run --generator=job/v1 is DEPRECATED and will be removed in a future version. Use kubectl run --generator=run-pod/v1 or kubectl create instead.
If you don't see a command prompt, try pressing enter.
[root@ip-10-0-167-30 ~]# oc get clusterversion 
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.1.0-0.nightly-2020-05-12-183253   True        False         74m     Cluster version is 4.1.0-0.nightly-2020-05-12-183253
[root@ip-10-0-167-30 ~]# oc version 
Client Version: version.Info{Major:"4", Minor:"1", GitVersion:"4.1.41-202004110309-d372a16", GitCommit:"d372a16738b45003f989bf67b2bcf604160b4583", GitTreeState:"clean", BuildDate:"2020-04-11T04:04:19Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.4-138-g41dc99c", GitCommit:"6458880", GitTreeState:"clean", BuildDate:"2020-05-02T04:08:43Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}

Comment 19 Red Hat Bugzilla 2023-09-14 04:33:54 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days