Bug 1624248

Summary: Bad UI after adding a schedule for report
Product: Red Hat CloudForms Management Engine Reporter: Parthvi Vala <pvala>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Parthvi Vala <pvala>
Severity: high Docs Contact:
Priority: high    
Version: 5.8.5CC: dmetzger, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.15 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1646564 (view as bug list) Environment:
Last Closed: 2019-02-12 16:50:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1646564    

Description Parthvi Vala 2018-08-31 06:14:11 UTC
Description of problem:
There are issues with UI after creating a schedule for any report. Once the schedule is created, UI is stuck - see the attachment for better understanding.

Version-Release number of selected component (if applicable):
5.8.5

How reproducible:
100%

Steps to Reproduce:
1.Navigate to Cloud Intel -> Reports and select the `Reports` accordion.
2. Select any report.
3. Click on `Configuration` and select `Add a new Schedule`.
4. Fill out the form and click on `Add` button. The schedule will be added successfully.
5. You will notice an inactive `Add` button and `Cancel` button at the bottom right corner.
6. Click on the `Cancel` button, nothing happens.
7. Try clicking on some other report. You will notice, "Choose a schedule to view from the menus on left" message.
8. Click on `Configuration` and select `Edit this Schedule`. `Add a new schedule` form will be visible on the screen.
9. Fill out the form, `Report Selection Filter` will be inactive, which will not allow you to add the schedule. Click on `Cancel`.
10. Select on `Queue up this Schedule to Run now`, this will generate a report.
10. Select `Delete this schedule` from the `Configuration` menu. You will see an error "Schedule is not available or no longer exists" and `All Schedules` page, but the selected accordion on side menu will still be `Reports`.

Actual results:
The schedule is added and runs successfully, but there are plenty of problems with UI.

Expected results:
The schedule must be added and there should not be any `Add` or `Cancel` buttons. The configuration menu should not show options to Edit, Queue and Delete the reports and the user must easily be able to navigate to other reports.

Additional info:
Tested this on 5.8.5, 5.9.z and 5.10.12, the problem persists on all the versions.
On 5.8.5, there are no additional `Add` and `Cancel` button after the schedule has been added, but there are still issues with `Configuration`, which shows options to Edit, Delete and queue in the menu.

Comment 7 CFME Bot 2018-09-07 15:08:26 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/62aec06c04997c34b682f95f21e08ca9ce10efe2
commit 62aec06c04997c34b682f95f21e08ca9ce10efe2
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Sep  6 11:28:09 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Sep  6 11:28:09 2018 -0400

    Fixed Schedules accordion swapping logic.

    Only need to set params[:accord] when add button is pressed from Reports accordion, setting of acord parameter causes acoridon to be swapped to Schedule accordion by Explorer presenter code. Undid code changes made in https://github.com/ManageIQ/manageiq-ui-classic/pull/3399 this was causing issues when adding a schedule from Reports accordion.
    Also need to hide form buttons post accordion switch when schedule is added from Reports accordion.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1624248

 app/assets/javascripts/miq_explorer.js | 3 +-
 app/controllers/report_controller.rb | 1 +
 app/controllers/report_controller/schedules.rb | 3 +-
 spec/controllers/report_controller/schedules_spec.rb | 31 +
 4 files changed, 34 insertions(+), 4 deletions(-)

Comment 8 Parthvi Vala 2018-09-18 06:43:34 UTC
Verified on 5.10.0.15.20180914163601_fb02d7e. It works perfectly. Great work!

Comment 10 Satoe Imaishi 2018-11-05 16:48:16 UTC
*** Bug 1636744 has been marked as a duplicate of this bug. ***