Bug 1624431

Summary: Memory threshold set from Workers tab doesn't work
Product: Red Hat CloudForms Management Engine Reporter: Tasos Papaioannou <tpapaioa>
Component: UI - OPSAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED CURRENTRELEASE QA Contact: Tasos Papaioannou <tpapaioa>
Severity: medium Docs Contact:
Priority: high    
Version: 5.9.4CC: abellott, dmetzger, gtanzill, hkataria, jrafanie, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: Regression, TestOnly, ZStream
Target Release: 5.10.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.10.0.16 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1629897 (view as bug list) Environment:
Last Closed: 2019-02-12 16:52:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1629897    

Comment 4 Joe Rafaniello 2018-09-05 19:47:37 UTC 
The advanced setting page works correctly if you specify "200.megabytes" or 209715200 as a number.  The UI dropdown on the workers tab are explicitly setting values as "209715200".  We support the to i with method way: "200.megabytes" if you want to store a human readable string value but we only support rails convenience methods like megabytes, hours, etc.  The backend for each setting field is dumb in terms of the type you're saving so they must be stored as the correct data type.  

Perhaps these commits might be related to this regression:

https://github.com/ManageIQ/manageiq-ui-classic/commit/271ab162a8f7d66704b558dcf93925868dff70ac

https://github.com/ManageIQ/manageiq-ui-classic/commit/47cf8bf456b1c7ce0c0504854af950539bca9202
Comment 6 Joe Rafaniello 2018-09-05 19:51:23 UTC 
Summary:  save "200.megabytes" or 209715200, not "209715200".
Comment 9 Milan Zázrivec 2018-09-10 14:27:50 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/4633
Comment 10 CFME Bot 2018-09-17 13:07:46 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/e602fdf1e9a0e4e8f3425696e9737ac08542a0bc
commit e602fdf1e9a0e4e8f3425696e9737ac08542a0bc
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Sep 10 10:25:28 2018 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Sep 10 10:25:28 2018 -0400

    Worker Settings: save memory threshold as integer

    Saving the memory threshold value as a string would prevent
    the value to be read / used correctly later by the worker itself.

    https://bugzilla.redhat.com/show_bug.cgi?id=1624431

 app/controllers/ops_controller/settings/common.rb | 40 +-
 1 file changed, 20 insertions(+), 20 deletions(-)
Comment 12 Tasos Papaioannou 2018-09-27 18:09:54 UTC 
Verified on 5.10.0.16.