Bug 1625175

Summary: Missing value in product details causes values to not align to their labels
Product: Red Hat Satellite Reporter: Mirek Długosz <mzalewsk>
Component: Subscription ManagementAssignee: Amir <afeferku>
Status: CLOSED ERRATA QA Contact: Mirek Długosz <mzalewsk>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.4CC: akofink, egolov, tstrachota
Target Milestone: 6.4.0Keywords: Regression, Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tfm-rubygem-katello-3.7.0.26-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-16 19:13:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot showing how page would look like with proposed fix (applied to HTML using browser web development tools)
none
Screenshot showing problem
none
Screenshot of page after fix none

Description Mirek Długosz 2018-09-04 10:25:32 UTC 
On Subscription details page, there are 4 values displayed for each product: Content Download URL, GPG Key URL, Repo Type and Enabled?. If one value is missing, it causes subsequent values to shift up and not align with their labels. See attached screenshot.


Version-Release number of selected component (if applicable):
Satellite 6.4.0 snap 20
tfm-rubygem-katello-3.7.0.22-1.el7sat.noarch


Steps to Reproduce:
1. Create new product. Make sure that GPG Key field remains empty. Add one yum repository: https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/zoo/
2. Content -> Subscriptions -> Product from previous step -> Enabled Products -> expand product
3. Try to read data


Solution:
The root cause is HTML structure displaying ultimately tabular data in column-oriented way instead of row-oriented way.


Instead of (simplified code):

<div class="col-sm-3">
   <div class="row">Label</div>
</div>
<div class="col-sm-9">
   <div class="row">value</div>
</div>

It should be:

<div class="row">
   <div class="col-sm-3">
      Label
   </div>
   <div class="col-sm-9">
      value
   </div>
</div>

New structure would also make data more readable on phones / very narrow screens. Right now it's all labels, all values, one under another. With new structure, it would be label, value, intertwined.
Comment 1 Mirek Długosz 2018-09-04 10:29:09 UTC 
Created attachment 1480736 [details]
Screenshot showing how page would look like with proposed fix (applied to HTML using browser web development tools)
Comment 2 Mirek Długosz 2018-09-04 10:30:17 UTC 
Created attachment 1480737 [details]
Screenshot showing problem
Comment 4 Andrew Kofink 2018-09-04 12:45:00 UTC 
Created redmine issue https://projects.theforeman.org/issues/24810 from this bug
Comment 5 Satellite Program 2018-09-06 14:06:04 UTC 
Upstream bug assigned to afeferku
Comment 6 Satellite Program 2018-09-06 14:06:07 UTC 
Upstream bug assigned to afeferku
Comment 7 Satellite Program 2018-09-06 20:05:59 UTC 
Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/24810 has been resolved.
Comment 9 Mirek Długosz 2018-09-18 17:36:04 UTC 
Missing value for one of fields no longer cause subsequent values to shift up. See attached screenshot.

Tested on Satellite 6.4 snap 22 (tfm-rubygem-katello-3.7.0.28-1).
Comment 10 Mirek Długosz 2018-09-18 17:36:51 UTC 
Created attachment 1484458 [details]
Screenshot of page after fix
Comment 11 Bryan Kearney 2018-10-16 19:13:34 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927