Bug 1625410

Summary: Review Request: perl-Dancer-Plugin-Database-Core - Shared core for Dancer and Dancer2 Database plugins
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-17 03:54:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1625411    

Description Emmanuel Seyman 2018-09-04 21:07:21 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Dancer-Plugin-Database-Core/perl-Dancer-Plugin-Database-Core.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Dancer-Plugin-Database-Core/perl-Dancer-Plugin-Database-Core-0.20-1.fc28.src.rpm
Description:
Dancer::Plugin::Database::Core is a shared core for Dancer and Dancer2
database plugins. This module should not be used directly. It is a
shared library for Dancer::Plugin::Database and
Dancer2::Plugin::Database modules.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2018-09-05 08:40:14 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Dancer-Plugin-Database-Core-0.20-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(DBI)
      1 perl(DBI::db)
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(strict)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Please filter DBI's subclass perl(DBI::db) - is not provided by perl-DBI.
     
$ rpm -qp --provides perl-Dancer-Plugin-Database-Core-0.20-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Dancer::Plugin::Database::Core) = 0.20
      1 perl-Dancer-Plugin-Database-Core = 0.20-1.fc30
      1 perl(Dancer::Plugin::Database::Core::Handle) = 0.16
Binary provides are Ok.

$ rpmlint ./perl-Dancer-Plugin-Database-Core*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.
Otherwise package looks good.
Approved

Comment 2 Emmanuel Seyman 2018-09-05 09:25:48 UTC
(In reply to Jitka Plesnikova from comment #1)
>
> FIX: Please filter DBI's subclass perl(DBI::db) - is not provided by
> perl-DBI.

Done.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Dancer-Plugin-Database-Core/perl-Dancer-Plugin-Database-Core.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Dancer-Plugin-Database-Core/perl-Dancer-Plugin-Database-Core-0.20-2.fc28.src.rpm

> Otherwise package looks good.
> Approved

Thank you, Jikta. I've requested the repo.

Comment 3 Gwyn Ciesla 2018-09-05 13:04:25 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Dancer-Plugin-Database-Core

Comment 4 Fedora Update System 2018-09-05 15:40:02 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d204dde0dd

Comment 5 Fedora Update System 2018-09-05 15:40:08 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9299082f5e

Comment 6 Fedora Update System 2018-09-05 21:28:33 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9299082f5e

Comment 7 Fedora Update System 2018-09-07 00:07:39 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d204dde0dd

Comment 8 Fedora Update System 2018-09-07 00:08:08 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d204dde0dd

Comment 9 Fedora Update System 2018-09-17 03:54:44 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2018-09-21 05:28:40 UTC
perl-Dancer-Plugin-Database-Core-0.20-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.