Bug 1625411

Summary: Review Request: perl-Dancer2-Plugin-Database - Easy database connections for Dancer2 applications
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-07 11:30:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1625410    
Bug Blocks:    

Description Emmanuel Seyman 2018-09-04 21:07:32 UTC 
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Dancer2-Plugin-Database/perl-Dancer2-Plugin-Database.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Dancer2-Plugin-Database/perl-Dancer2-Plugin-Database-2.17-1.fc28.src.rpm
Description:
Dancer2::Plugin::Database provides an easy way to obtain a connected
DBI database handle by simply calling the database keyword within
your Dancer2 application

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 1 Robert-André Mauchin 🐧 2018-09-05 16:56:52 UTC 
URL and Source addresses are Ok.
Source archive (SHA-256: 431f3405413366d2f36ebe0fd4661cc6d3c1354ba46018484799c0757dc638bd) is original. Ok.
Summary verified from lib/Dancer2/Plugin/Database.pm. Ok.
Description verified from lib/Dancer2/Plugin/Database.pm. Ok.
License verified from lib/Dancer2/Plugin/Database.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.


 -Build fails:

Erreur de construction de RPM :
BUILDSTDERR: erreur : Fichier(s) installé(s) (mais non empaquetés) :
BUILDSTDERR:    /usr/lib64/perl5/vendor_perl/auto/Dancer2/Plugin/Database/.packlist
BUILDSTDERR:     Fichier(s) installé(s) (mais non empaquetés) :
BUILDSTDERR:    /usr/lib64/perl5/vendor_perl/auto/Dancer2/Plugin/Database/.packlist
Child return code was: 1

   Use:

perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1


$ rpmlint perl-Dancer2-Plugin-Database.spec review-perl-Dancer2-Plugin-Database/results/perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm review-perl-Dancer2-Plugin-Database/results/perl-Dancer2-Plugin-Database-2.17-1.fc30.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.


$ rpm -q -lv -p perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm                                        18:51:42
drwxr-xr-x    2 root    root                        0 sept.  5 18:46 /usr/share/doc/perl-Dancer2-Plugin-Database
-rw-r--r--    1 root    root                     1952 août 13  2016 /usr/share/doc/perl-Dancer2-Plugin-Database/Changes
-rw-r--r--    1 root    root                    13724 août  5  2016 /usr/share/doc/perl-Dancer2-Plugin-Database/README
-rw-r--r--    1 root    root                     6433 sept.  5 18:46 /usr/share/man/man3/Dancer2::Plugin::Database.3pm.gz
drwxr-xr-x    2 root    root                        0 sept.  5 18:46 /usr/share/perl5/vendor_perl/Dancer2
drwxr-xr-x    2 root    root                        0 sept.  5 18:46 /usr/share/perl5/vendor_perl/Dancer2/Plugin
-rw-r--r--    1 root    root                    14516 août 13  2016 /usr/share/perl5/vendor_perl/Dancer2/Plugin/Database.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm | sort -f | uniq -c             18:52:44
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(Dancer2::Plugin)
      1 perl(Dancer::Plugin::Database::Core)
      1 perl(Dancer::Plugin::Database::Core::Handle)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Dancer2-Plugin-Database-2.17-1.fc30.noarch.rpm                                 18:55:02
perl(Dancer2::Plugin::Database) = 2.17
perl-Dancer2-Plugin-Database = 2.17-1.fc30
Binary provides are Ok.


Package builds in mock F30.
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved. Please fix the aforementioned issue before import.
Comment 2 Gwyn Ciesla 2018-09-05 20:46:40 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Dancer2-Plugin-Database
Comment 3 Emmanuel Seyman 2018-09-05 20:52:28 UTC 
(In reply to Robert-André Mauchin from comment #1)
>
> perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1


I knew I forgot something...

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Dancer2-Plugin-Database/perl-Dancer2-Plugin-Database.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Dancer2-Plugin-Database/perl-Dancer2-Plugin-Database-2.17-2.fc28.src.rpm

> Resolution: Package approved. Please fix the aforementioned issue before
> import.

Repository requested. Thank you, Robert-André!
Comment 4 Emmanuel Seyman 2018-10-07 11:30:38 UTC 
This is now available as an update.