Bug 1625591

Created attachment 1481038 [details]
vdsm.log

Description of problem:

After importing a KVM VM successfully, then removing the VM successfully attempting to re-import the same VM fails. 

Version-Release number of selected component (if applicable):


How reproducible:

Always


Steps to Reproduce:
1. Import a KVM Virtual Machine to oVirt.
2. Remove the Virtual Machine from oVirt.
3. Attempt to re-import the same Virtual Machine

Actual results:

The second import fails due to an error that the Job ID already exists. The Job Id is the VM Id sent from the engine to the vdsm both when instantiating the import and when deleting the VM from the vdsm's list created by _add_job routine.

The error in the vdsm log is here:

2018-09-05 12:12:44,496+0300 ERROR (jsonrpc/1) [jsonrpc.JsonRpcServer] Internal server error (__init__:611)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line 606, in _handle_request
    res = method(**params)
  File "/usr/lib/python2.7/site-packages/vdsm/rpc/Bridge.py", line 201, in _dynamicMethod
    result = fn(*methodArgs)
  File "<string>", line 2, in convertExternalVm
  File "/usr/lib/python2.7/site-packages/vdsm/common/api.py", line 48, in method
    ret = func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/API.py", line 1485, in convertExternalVm
    self._irs)
  File "/usr/lib/python2.7/site-packages/vdsm/v2v.py", line 222, in convert_external_vm
    _add_job(job_id, job)
  File "/usr/lib/python2.7/site-packages/vdsm/v2v.py", line 304, in _add_job
    raise JobExistsError("Job %r exists" % job_id)
JobExistsError: Job u'dc5c81ff-35a8-4b90-82aa-b316ebeac65e' exists


This error also occurs later in the log:

2018-09-05 12:12:47,910+0300 ERROR (tasks/2) [storage.TaskManager.Task] (Task='fc8b7bf8-8732-4558-b34a-5fdf1ad12cda') Unexpected error (task:875)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 882, in _run
    return fn(*args, **kargs)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/task.py", line 336, in run
    return self.cmd(*self.argslist, **self.argsdict)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/securable.py", line 79, in wrapper
    return method(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/sp.py", line 1986, in purgeImage
    domain.purgeImage(sdUUID, imgUUID, volsByImg, discard)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/sd.py", line 710, in purgeImage
    self._manifest.purgeImage(sdUUID, imgUUID, volsImgs, discard)
  File "/usr/lib/python2.7/site-packages/vdsm/storage/fileSD.py", line 261, in purgeImage
    raise se.ImageDeleteError("%s %s" % (imgUUID, str(e)))
ImageDeleteError: Could not remove all image's volumes: (u'502e0a88-0918-42ba-aad7-94228bebd39e [Errno 39] Directory not empty',)

Note that the deleteV2VJob function is called after the Job exists error:

2018-09-05 12:12:45,584+0300 INFO  (jsonrpc/0) [api.host] START deleteV2VJob(jobid=u'dc5c81ff-35a8-4b90-82aa-b316ebeac65e') from=::ffff:10.35.1.148,40530, flow_id=0852c0ce-26bc-4a57-bcc2-112f1f30f9d9 (api:46)



Expected results:

The Import should succeed as it did the first time


Additional info:

Attached vdsm log

Note, the problem may be in the engine code which initiates the call to the deleteV2VJob function.