Bug 1625649
| Summary: | Yum plugins are loaded multiple times after updating the host to the latest katello-agent packages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Mihir Lele <mlele> | ||||
| Component: | katello-agent | Assignee: | Jonathon Turel <jturel> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Jan Hutař <jhutar> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 6.4 | CC: | ahumbe, akarimi, akolomitz, alexander.lackner, arusso, bbuckingham, bkearney, bwallace, cpatters, dgross, emil.sylvio.golinelli, jbhatia, jsherril, jturel, kkohli, ktordeur, mlele, mmccune, mtenheuv, mvanderw, nhall, patalber, pcreech, peter.vreman, rbertolj, richard.sipinski, sadas, sghai, smajumda, sraut, suarora, swa, systems, tonay, vcojot, vwariyal, yferszt | ||||
| Target Milestone: | 6.5.0 | Keywords: | Triaged | ||||
| Target Release: | Unused | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1684690 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-05-14 12:37:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1122832, 1619394 | ||||||
| Attachments: |
|
||||||
|
Description
Mihir Lele
2018-09-05 12:58:51 UTC
Here's a simple way to reproduce the issue: [root@rhel7test1 ~]# katello-enabled-repos-upload Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Loaded plugins: product-id, subscription-manager Version info: [root@rhel7test1 ~]# rpm -qa katello-host-tools katello-host-tools-3.3.5-3.el7sat.noarch Notes: I traced the issue through the Katello python packages to the '_obtain_mappings_yum()' method in /usr/lib/python2.7/site-packages/katello/enabled_report.py. From there it jumps to the yum library where I lost track of what's going on. Created attachment 1497111 [details]
Obtain mappings outside of loop
Proposed patch to katello/enabled_report.py that moves the call to _obtain_mappings() outside the loop preventing Yum plugins from loading multiple times and fixing the issue.
Connecting redmine issue http://projects.theforeman.org/issues/25173 from this bug Hi Ché, to my knowledge this is a regression in 6.4 so it shouldn't be happening to 6.3 customers. Do you have any cases to the contrary? Brad - can you comment on whether we should release a hotfix or wait for the next 6.4.z ? I can't seem to find a date for it Will this be fixed in a 6.4.z release?? Or will we really have to wait all the way until 6.5.0 to get this fixed??! I would very much like a hotfix if we are being forced to wait until 6.5.0 to get this fixed (which is pretty disappointing if so)... Hi Yaniv, which version of katello-host-tools is running on their clients? That's the package we'll need to hotfix One thing I would like to clarify is that the fix here addresses only the slow generation of the enabled repositories report. The performance issue is totally on the client side and there shouldn't be any additional requests being sent to the server. Some of the earlier comments have led me to believe there is a misconception that for each iteration of "Loaded plugins..." that there are extra requests being sent to the server and that should not be the case. (In reply to Matt from comment #22) > Will this be fixed in a 6.4.z release?? Or will we really have to wait all > the way until 6.5.0 to get this fixed??! > > I would very much like a hotfix if we are being forced to wait until 6.5.0 > to get this fixed (which is pretty disappointing if so)... Asking the good questions Matt! Sadly no response... (In reply to Emil from comment #41) > (In reply to Matt from comment #22) > > Will this be fixed in a 6.4.z release?? Or will we really have to wait all > > the way until 6.5.0 to get this fixed??! > > > > I would very much like a hotfix if we are being forced to wait until 6.5.0 > > to get this fixed (which is pretty disappointing if so)... > > Asking the good questions Matt! Sadly no response... This is now targeted for 6.4.3 The release date is not definite at this point, so if there is a need for a hotfix please reach out to Red Hat support. This bug was cloned and is still going to be included in the 6.4.3 release. It no longer has the sat-6.4.z+ flag and 6.4.3 Target Milestone Set which are now on the 6.4.z cloned bug. Please see the Clones field to track the progress of this bug in the 6.4.3 release. (In reply to Jonathon Turel from comment #19) > Hi Ché, to my knowledge this is a regression in 6.4 so it shouldn't be > happening to 6.3 customers. Do you have any cases to the contrary? I am currently seeing this behavior on Satellite 6.3.5 with katello-host-tools-3.1.0-2.el7sat.noarch. Please let me know what information you require, as I am happy to help. (In reply to akolomitz from comment #44) > (In reply to Jonathon Turel from comment #19) > > Hi Ché, to my knowledge this is a regression in 6.4 so it shouldn't be > > happening to 6.3 customers. Do you have any cases to the contrary? > > I am currently seeing this behavior on Satellite 6.3.5 with > katello-host-tools-3.1.0-2.el7sat.noarch. Please let me know what > information you require, as I am happy to help. I'm confident this bug doesn't affect katello-host-tools-3.1.0 because the area of code which introduced the problem doesn't exist in that version. The bug here reports that yum plugins are loaded once for each repository enabled on the system. Here's my client with tools version 3.1.0 and over 20 enabled repos: > yum repolist Loaded plugins: enabled_repos_upload, fastestmirror, package_upload, product-id, : search-disabled-repos, subscription-manager Loading mirror speeds from cached hostfile * base: packages.oit.ncsu.edu * epel: download-ib01.fedoraproject.org * extras: distro.ibiblio.org * updates: packages.oit.ncsu.edu repo id status <SNIP 30+ more repos> base/7/x86_64 10,019 cr/7/x86_64 0 epel/x86_64 13,030 extras/7/x86_64 385 updates/7/x86_64 1,477 repolist: 26,950 Uploading Enabled Repositories Report Loaded plugins: fastestmirror, product-id, subscription-manager At the end you can see that plugins are loaded only once (twice if you count the initial yum command). On a system exhibiting this bug the output "Loaded plugins: fastestmirror, product-id, subscription-manager" would be repeated for each enabled repository which would have been about 40 times on my test system. Can you provide some more details - output etc? Perhaps there's a separate issue. As the original reporter of the regression seen starting with 6.4.0Beta i confirm it is fixed in 6.5.0Beta Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:1222 |