Bug 1625692

Summary:	Service status summary showing OK when services are inactive
Product:	Red Hat Satellite	Reporter:	Taft Sanders <tasander>
Component:	Satellite Maintain	Assignee:	Martin Bacovsky <mbacovsk>
Status:	CLOSED ERRATA	QA Contact:	Stephen Wadeley <swadeley>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	6.4	CC:	apatel, cmarinea, inecas, kgaikwad, mbacovsk, pcreech, swadeley
Target Milestone:	6.4.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	All
Whiteboard:
Fixed In Version:	foreman_maintain-0.2.10-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-16 15:16:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Taft Sanders 2018-09-05 14:50:22 UTC

Description of problem:
When checking services on the Satellite using 'foreman-maintain service status' the summary at the bottom shows "OK" when services are dead or inactive.

Version-Release number of selected component (if applicable):
6.4

How reproducible:
Everytime

Steps to Reproduce:
1. Start Satellite services
2. Systemctl stop httpd
3. Check services with 'foreman-maintain service status'

Actual results:
- displaying puppetserver                                                       

● puppetserver.service - puppetserver Service
   Loaded: loaded (/usr/lib/systemd/system/puppetserver.service; enabled; vendor preset: disabled)
   Active: inactive (dead) since Wed 2018-09-05 10:49:29 EDT; 5s ago
  Process: 7512 ExecStop=/opt/puppetlabs/server/apps/puppetserver/bin/puppetserver stop (code=exited, status=0/SUCCESS)
  Process: 5576 ExecStart=/opt/puppetlabs/server/apps/puppetserver/bin/puppetserver start (code=exited, status=0/SUCCESS)
 Main PID: 5607 (code=exited, status=143)

Sep 05 10:43:02 sat64htb.usersys.redhat.com systemd[1]: Starting puppetserver Service...
Sep 05 10:44:03 sat64htb.usersys.redhat.com systemd[1]: Started puppetserver Service.
Sep 05 10:49:28 sat64htb.usersys.redhat.com systemd[1]: Stopping puppetserver Service...
Sep 05 10:49:29 sat64htb.usersys.redhat.com systemd[1]: Stopped puppetserver Service.


- All services displayed                                              [OK]      
--------------------------------------------------------------------------------


Expected results:
- displaying puppetserver                                                       

● puppetserver.service - puppetserver Service
   Loaded: loaded (/usr/lib/systemd/system/puppetserver.service; enabled; vendor preset: disabled)
   Active: inactive (dead) since Wed 2018-09-05 10:49:29 EDT; 5s ago
  Process: 7512 ExecStop=/opt/puppetlabs/server/apps/puppetserver/bin/puppetserver stop (code=exited, status=0/SUCCESS)
  Process: 5576 ExecStart=/opt/puppetlabs/server/apps/puppetserver/bin/puppetserver start (code=exited, status=0/SUCCESS)
 Main PID: 5607 (code=exited, status=143)

Sep 05 10:43:02 sat64htb.usersys.redhat.com systemd[1]: Starting puppetserver Service...
Sep 05 10:44:03 sat64htb.usersys.redhat.com systemd[1]: Started puppetserver Service.
Sep 05 10:49:28 sat64htb.usersys.redhat.com systemd[1]: Stopping puppetserver Service...
Sep 05 10:49:29 sat64htb.usersys.redhat.com systemd[1]: Stopped puppetserver Service.


- All services displayed                                              puppetserver: FAILED      
--------------------------------------------------------------------------------


Additional info:

Comment 1 Christian Marineau 2018-09-05 15:10:56 UTC

Additional observation, when a mandatory service is stopped like httpd:

katello-service will return a warning and also an exit status of "1" as expected
  # katello-service status
  # echo $?
  1

foreman-maintain will not return any warning, and the exit status will be "0"
  # foreman-maintain service status
  # echo $?
  0

It is very important for users to get the same behavior with the new tooling, so any monitoring or script in place can still work despite this change.

Comment 3 Kavita 2018-09-11 12:57:44 UTC

Created redmine issue http://projects.theforeman.org/issues/24891 from this bug

Comment 4 Satellite Program 2018-09-14 10:08:16 UTC

Upstream bug assigned to apatel

Comment 5 Satellite Program 2018-09-19 14:08:38 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/24891 has been resolved.

Comment 7 Patrick Creech 2018-09-24 14:48:51 UTC

snap 23, not 63

Comment 12 errata-xmlrpc 2018-10-16 15:16:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:2926