Bug 1626134
Summary: | Review Request: fips - OpenGL-based FITS image viewer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matwey V. Kornilov <matwey.kornilov> |
Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | lemenkov, package-review, zebob.m |
Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-11-20 13:55:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matwey V. Kornilov
2018-09-06 16:00:32 UTC
- LGPL-3.0 is not a valid license shorthand. See valid list here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses License: LGPLv3 - Group is not used in Fedora. See https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - BuildRoot: %{_tmppath}/%{name}-%{version}-build is not used anymore - Not useful as it is the default already: %defattr(-,root,root) - The license file must be installed with %license, not %doc: %license LICENSE.txt %doc README.md - This is not really the way to do it: %dir %{_datadir}/icons/hicolor %dir %{_datadir}/icons/hicolor/128x128 %dir %{_datadir}/icons/hicolor/128x128/apps %{_datadir}/icons/hicolor/128x128/apps/space.fips.Fips.png %dir %{_datadir}/icons/hicolor/256x256 %dir %{_datadir}/icons/hicolor/256x256/apps %{_datadir}/icons/hicolor/256x256/apps/space.fips.Fips.png %dir %{_datadir}/icons/hicolor/scalable %dir %{_datadir}/icons/hicolor/scalable/apps %{_datadir}/icons/hicolor/scalable/apps/space.fips.Fips.svg Just use: %{_datadir}/icons/hicolor/*/apps/space.fips.Fips.* And then to own the icons directories, depend on hicolor-icon-theme: Requires: hicolor-icon-theme Thank you. V2 revision is the following: Spec URL: https://transfer.sh/VwY8n/fips.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2292/29552292/fips-3.3.0-1.fc30.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=29552291 I'll sponsor Matwey, and I'll review it. Unblocking FE-NEEDSPONSOR - I've just sponsored Matwey. REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is almost silent: lemenkov ~/Downloads: rpmlint fips-* fips.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/fips <urlopen error _ssl.c:1029: The handshake operation timed out> ^^^ Not yet available but will be when we add this package. fips.x86_64: W: no-manual-page-for-binary fips ^^^ Sad but true. fips-debugsource.x86_64: W: invalid-url BugURL: https://bugz.fedoraproject.org/fips <urlopen error _ssl.c:1029: The handshake operation timed out> ^^^ See above. 4 packages and 0 specfiles checked; 0 errors, 3 warnings. lemenkov ~/Downloads: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. All Robert-André's notes above were addressed. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. - I believe that the correct lincense field value is LGPLv3+ rather than LGPLv3. + The file, containing the text of the license(s) for the package, is included as %license. + The spec file is written in American English. + The spec file for the package is legible. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No C/C++ header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so) in some of the dynamic linker's default paths. 0 No devel sub-package. + The package does NOT contain any .la libtool archives. + The package includes a %{name}.desktop file, and this file is properly installed with desktop-file-install in the %install section. + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8. APPROVED. Please fix License field before uploading. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fips |