Bug 1626152

Summary:	Embedded Ansible needs a retry interval. We are currently setting limit and not interval.
Product:	Red Hat CloudForms Management Engine	Reporter:	William Fitzgerald <wfitzger>
Component:	Automate	Assignee:	Drew Bomhof <dbomhof>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Satyajit Bulage <sbulage>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.9.5	CC:	dbomhof, dmetzger, mkanoor, obarenbo, simaishi, smallamp, tfitzger
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.10.0.22	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1646629 (view as bug list)		Environment:
Last Closed:	2019-02-12 16:53:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1646629

Description William Fitzgerald 2018-09-06 16:42:57 UTC

Description of problem: Embedded Ansible needs a retry interval.
When you set interval in a playbook, it is setting ae_retry_limit and should be setting ae_retry_interval.
We also need a default ae_retry_interval of 60 seconds if not interval is not set.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Drew Bomhof 2018-09-06 18:07:21 UTC

Commit: https://github.com/syncrou/manageiq-automate/commit/58cc594c6721f7bc19d8dcebc0a524424fd51895

Comment 3 Drew Bomhof 2018-09-06 19:06:11 UTC

Commit: https://github.com/syncrou/manageiq-automate/commit/f47fc79223affd5eac7e9dd36ca08ce9dbe269ee

Set default interval to 60 if an empty string is passed in.

Comment 4 William Fitzgerald 2018-09-13 13:17:03 UTC

Drew,

I tested this on a 5.9.4.5 appliance and it works.

Billy

Comment 9 CFME Bot 2018-10-26 22:08:55 UTC

New commit detected on ManageIQ/manageiq-content/hammer:

https://github.com/ManageIQ/manageiq-content/commit/48b25f88709d8f155471e084eb72f483bff3cbd5
commit 48b25f88709d8f155471e084eb72f483bff3cbd5
Author:     Greg McCullough <gmccullo>
AuthorDate: Fri Oct 26 12:13:53 2018 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Fri Oct 26 12:13:53 2018 -0400

    Merge pull request #454 from syncrou/add_manageiq_automate_changes

    Add manageiq automate changes

    (cherry picked from commit 6c377d9279cbf8f3b52a9f773dfe25dd69ee9140)

    https://bugzilla.redhat.com/show_bug.cgi?id=1626152

 content/ansible/roles/manageiq-core.manageiq-automate/library/manageiq_automate.py | 13 +-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comment 11 Satyajit Bulage 2019-01-04 06:58:57 UTC

With help of William following steps used to verify it.

1. Enable Embedded Ansible
2. Add repo - Suggest https://github.com/billfitzgerald0120/ansible_playbooks
3. Import Ansible_StateMachine_Set_Retry
4. Enable domain
5. Verify the Playbook method (set_retry_4_times) or use your own playbook
6. Add a dummy dialog
7. Add a catalog
8. Add a new Catalog item (Generic Type)
9. Order service
10. Check automation.log to make sure the playbook retry is waiting at least 60 seconds before trying again

Service retried by waiting atleast 60 seconds and found that Playbook didn't failed.


Verified Version: 5.10.0.29.20181211195209_fd990a9