Bug 1626517

Summary: group crippled in /usr/sbin/if(up|down)
Product: Red Hat Enterprise Linux 7 Reporter: Vladimir Benes <vbenes>
Component: NetworkManagerAssignee: Beniamino Galvani <bgalvani>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.6CC: atragler, bgalvani, fgiudici, jomurphy, lrintel, rkhan, sukulkar, thaller
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.12.0-6.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-30 11:14:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
[PATCH] contrib/rpm: fix mode of ghost ifup/ifdown files none

Description Vladimir Benes 2018-09-07 14:11:05 UTC 
Description of problem:
[root@wsfd-netdev34-vm-3 ~]# rpm -qlv NetworkManager |egrep 'if(up|down)'
-rwxr-xr-x    1 root    root                      155 Aug 19 09:22 /usr/libexec/nm-ifdown
-rwxr-xr-x    1 root    root                      153 Aug 19 09:22 /usr/libexec/nm-ifup
-rw-r--r--    1 root    root                        0 Aug 19 09:22 /usr/sbin/ifdown
-rw-r--r--    1 root    root                        0 Aug 19 09:22 /usr/sbin/ifup
[root@wsfd-netdev34-vm-3 ~]# rpm -qlv initscripts |egrep 'if(up|down)'
lrwxrwxrwx    1 root    root                       24 Jul 25 06:14 /etc/sysconfig/network-scripts/ifdown -> ../../../usr/sbin/ifdown
-rwxr-xr-x    1 root    root                      654 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-bnep
-rwxr-xr-x    1 root    root                     6532 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-eth
-rwxr-xr-x    1 root    root                      781 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-ippp
-rwxr-xr-x    1 root    root                     4540 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-ipv6
lrwxrwxrwx    1 root    root                       11 Jul 25 06:14 /etc/sysconfig/network-scripts/ifdown-isdn -> ifdown-ippp
-rwxr-xr-x    1 root    root                     2130 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-post
-rwxr-xr-x    1 root    root                     1068 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-ppp
-rwxr-xr-x    1 root    root                      870 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-routes
-rwxr-xr-x    1 root    root                     1456 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-sit
-rwxr-xr-x    1 root    root                     1462 Jul 24 10:47 /etc/sysconfig/network-scripts/ifdown-tunnel
lrwxrwxrwx    1 root    root                       22 Jul 25 06:14 /etc/sysconfig/network-scripts/ifup -> ../../../usr/sbin/ifup
-rwxr-xr-x    1 root    root                    12415 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-aliases
-rwxr-xr-x    1 root    root                      910 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-bnep
-rwxr-xr-x    1 root    root                    13475 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-eth
-rwxr-xr-x    1 root    root                    12075 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-ippp
-rwxr-xr-x    1 root    root                    11893 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-ipv6
lrwxrwxrwx    1 root    root                        9 Jul 25 06:14 /etc/sysconfig/network-scripts/ifup-isdn -> ifup-ippp
-rwxr-xr-x    1 root    root                      650 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-plip
-rwxr-xr-x    1 root    root                     1064 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-plusb
-rwxr-xr-x    1 root    root                     5000 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-post
-rwxr-xr-x    1 root    root                     4154 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-ppp
-rwxr-xr-x    1 root    root                     2001 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-routes
-rwxr-xr-x    1 root    root                     3303 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-sit
-rwxr-xr-x    1 root    root                     2711 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-tunnel
-rwxr-xr-x    1 root    root                     1836 Jul 24 10:47 /etc/sysconfig/network-scripts/ifup-wireless
-rwxr-xr-x    1 root    root                     1651 Jul 24 10:47 /usr/sbin/ifdown
-rwxr-xr-x    1 root    root                     5010 Jul 24 10:47 /usr/sbin/ifup
lrwxrwxrwx    1 root    root                        9 Jul 25 06:14 /usr/share/man/man8/ifdown.8.gz -> ifup.8.gz
-rw-r--r--    1 root    root                      555 Jul 25 06:14 /usr/share/man/man8/ifup.8.gz
[root@wsfd-netdev34-vm-3 ~]# rpm -qlv initscripts |egrep 'if(up|down)' |grep sbin
lrwxrwxrwx    1 root    root                       24 Jul 25 06:14 /etc/sysconfig/network-scripts/ifdown -> ../../../usr/sbin/ifdown
lrwxrwxrwx    1 root    root                       22 Jul 25 06:14 /etc/sysconfig/network-scripts/ifup -> ../../../usr/sbin/ifup
-rwxr-xr-x    1 root    root                     1651 Jul 24 10:47 /usr/sbin/ifdown
-rwxr-xr-x    1 root    root                     5010 Jul 24 10:47 /usr/sbin/ifup

[root@wsfd-netdev34-vm-3 ~]# rpm -V NetworkManager
.M.......  g /usr/sbin/ifdown
.M.......  g /usr/sbin/ifup


Version-Release number of selected component (if applicable):
NetworkManager-1.12.0-3.el7.x86_64
Comment 1 Beniamino Galvani 2018-09-13 08:16:24 UTC 
Created attachment 1482950 [details]
[PATCH] contrib/rpm: fix mode of ghost ifup/ifdown files
Comment 2 Thomas Haller 2018-09-13 09:44:59 UTC 
(In reply to Beniamino Galvani from comment #1)
> Created attachment 1482950 [details]
> [PATCH] contrib/rpm: fix mode of ghost ifup/ifdown files

lgtm
Comment 3 Thomas Haller 2018-09-14 13:14:48 UTC 
merged upstream:

master:  https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=d8a972c575c44b39dd170ab58d6a8937f7893d3f
nm-1-14: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=63639f338fcf5380e0606ea32aefce1273497164
nm-1-12: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6542edef4cbbd3081efd9ed5aa95494bdd016d4c
Comment 5 Vladimir Benes 2018-09-18 14:32:01 UTC 
[root@gsm-r6s14-01 NetworkManager-ci]# rpm -V NetworkManager
[root@gsm-r6s14-01 NetworkManager-ci]# echo $?
0
Comment 7 errata-xmlrpc 2018-10-30 11:14:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3207