Bug 1627250
| Summary: | Retire python-glusterfs-api in Fedora 30+ (or switch it to python3 only) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | python-glusterfs-api | Assignee: | Kaleb KEITHLEY <kkeithle> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | cstratak, humble.devassy, igor.raits, kkeithle, mhroncok, ngompa13, ppai, pviktori, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-glusterfs-api-1.2-1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-09-26 17:16:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1285816, 1625773 | ||
|
Description
Miro Hrončok
2018-09-10 14:06:20 UTC
Prasanth, what's the status of this? I see that a couple of files in https://github.com/gluster/libgfapi-python/blob/master/gluster/... have been updated with commit message "Port to Python 3.x" and I see some python3-isms, but no new Release/tag has been made. Also https://files.pythonhosted.org/packages/source/g/gfapi/%{python_package_name}-%{version}.tar.gz gives a 404 error. top-level https://files.pythonhosted.org now sends people to to https://pypi.org and I don't see any evidence at https://pypi.org/project/gfapi/ that anything has changed. Is it python3 ready? Can we get a 1.2 or 2.0 tag? If so I'll update the package in Fedora and save it from being retired. Thanks The libgfapi-python project now supports both python2 and python3. However, it doesn't conform to the Fedora packaging guidelines about the shebang lines yet. I'll look into that. Please do not retire it. We are working on making it python3. Do you need help with the shebangs? I can send a PR for the spec as long as it's gfapi 1.1 that works with Python 3. gfapi-1.1 is not the version that works with py3. The shebangs need to be fixed and a 1.2 or 2.0 release/tag made. I would also like to know what is currently considered the authoritative source: https://files.pythonhosted.org/packages/source/g/gfapi (dead, so probably not) or https://pypi.org/project/gfapi/ (where I can't find a source tarball) or https://github.com/gluster/libgfapi-python (which says it's only a mirror of pythonhosted) (In reply to Kaleb KEITHLEY from comment #5) > gfapi-1.1 is not the version that works with py3. > > The shebangs need to be fixed and a 1.2 or 2.0 release/tag made. > > I would also like to know what is currently considered the authoritative > source: > https://files.pythonhosted.org/packages/source/g/gfapi (dead, so probably > not) > or > https://pypi.org/project/gfapi/ (where I can't find a source tarball) > or > https://github.com/gluster/libgfapi-python (which says it's only a mirror > of pythonhosted) I'll update this BZ when I cut out the release. The guideline at https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines explicitly states - "Files which are not installed as executables SHOULD NOT have shebang lines". As the python bindings is a library without any executable, the shebang rule is not applicable. fixed in python-glusterfs-api-1.2-1.fc29 and python-glusterfs-api-1.2-1.fc30 |