Bug 1627256
Summary: | Switch pyflowtools to Python3 in Fedora 30+ | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
Component: | pyflowtools | Assignee: | Paul P Komkoff Jr <i> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | cstratak, igor.raits, i, mhroncok, ngompa13, pviktori, zbyszek |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | pyflowtools-0.3.4.2-2.fc30 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-02-02 21:15:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1625773 |
Description
Miro Hrončok
2018-09-10 14:06:56 UTC
I (or someone) needs to port it to py3. The repo is here: http://github.com/theraphim/pyflowtools I won't be able to do it in the next month, but may have some time after that. The repo is exported from Google Code and last commit is from 2011. Maybe it would be wiser just to retire the package? I know, this is my repo (as it was on google code), and I did the export. It's certainly easier, but I know people who are still using pyflowtools :\ Hi, I did a quick port of the extension code to python3, but I don't know how to test it, 'cause I have no idea what those "flows" are. Could you send (attach here) some input files for testing, ideally along with the expected outputs? I'll check then that this works correctly under py2 and py3 and send the patches. Sorry, I had a few busy days. Here are 3 files for you to test: https://stingr.net/.ft/ flowtools.c: In function ‘FlowPDU_IsAdjacent_Helper’: flowtools.c:667:21: warning: self-comparison always evaluates to true [-Wtautological-compare] (o2->unix_nsecs <= o2->unix_nsecs); ^~ This looks like a bug. Paul, what's the status? Could you take Zbyszek's code and make this package python3? I merged it now. I need a few days to build the package - traveling :( Thanks. Thanks for the update. Travel safely. Paul, any update here please? Sorry, dropped this one. If this build https://koji.fedoraproject.org/koji/taskinfo?taskID=32127667 will work I'll fix up a few nits later today and it should be good to go for F30. BUILDSTDERR: /var/tmp/rpm-tmp.fBa6gj: line 32: python: command not found Don't use "python setup.py build", use %py3_build. |