Bug 1627273

Summary: Fields username and password are not displayed for ftp log depot settings
Product: Red Hat CloudForms Management Engine Reporter: Angelina Vasileva <anikifor>
Component: UI - OPSAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED CURRENTRELEASE QA Contact: Angelina Vasileva <anikifor>
Severity: high Docs Contact:
Priority: high    
Version: 5.10.0CC: dmetzger, hkataria, lavenel, mfeifer, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: Regression
Target Release: 5.10.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.10.0.19 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-12 16:51:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
works in 5.9
none
no username and password in 5.10 none

Description Angelina Vasileva 2018-09-10 14:22:47 UTC 
Description of problem:
Fields username and password are not displayed for ftp log depot setting for log collection.

Version-Release number of selected component (if applicable):
5.10.0.14.20180831154906_2f9a1dd

How reproducible:
always

Steps to Reproduce:
1. Open the menu in upper right corner -> Configuration
2. In the left menu select Diagnostics -> Click on the name of the server
3. Click on Collect Logs tab
4. Click Edit
5. Select Type: FTP

Actual results:
Fields "Depot Name" and "URI" are displayed.

Expected results:
Fields "Depot Name", "URI", "Username" and "Password" are displayed.

Additional info:
It's possible to save Log depot settings without username/password. With these setting we will have an error "no implicit conversion of nil into String" when trying to collect logs.
Comment 3 Angelina Vasileva 2018-09-10 14:26:01 UTC 
Created attachment 1482144 [details]
works in 5.9
Comment 4 Angelina Vasileva 2018-09-10 14:26:43 UTC 
Created attachment 1482145 [details]
no username and password in 5.10
Comment 5 CFME Bot 2018-09-19 13:52:41 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/4682
Comment 6 Angelina Vasileva 2018-10-11 12:14:21 UTC 
Fixed and verified in 5.10.0.19.20181009184346_1c8bf5d
Comment 7 CFME Bot 2018-10-11 14:30:22 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/52f5954bd1d100e8d52bcb02a5b897ffba3f6710
commit 52f5954bd1d100e8d52bcb02a5b897ffba3f6710
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Wed Sep 19 09:34:42 2018 -0400
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Wed Sep 19 09:34:42 2018 -0400

    FTP log depot: bring back credential inputs

    https://bugzilla.redhat.com/show_bug.cgi?id=1627273

 app/assets/javascripts/services/miq_db_backup_service.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 CFME Bot 2018-10-11 14:30:29 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/6c7804e65f69cdc07d367a41b518ba410d0807d2
commit 6c7804e65f69cdc07d367a41b518ba410d0807d2
Author:     Martin Povolny <mpovolny>
AuthorDate: Mon Oct  8 11:13:21 2018 -0400
Commit:     Martin Povolny <mpovolny>
CommitDate: Mon Oct  8 11:13:21 2018 -0400

    Merge pull request #4682 from mzazrivec/fix_ftp_credentials_for_log_depot

    Fix FTP credentials for log depot

    (cherry picked from commit 15915b21a63e9df1d86f014b38388451e8bb7f5e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1627273

 app/assets/javascripts/services/miq_db_backup_service.js | 2 +-
 app/views/ops/_log_collection.html.haml | 18 +-
 2 files changed, 10 insertions(+), 10 deletions(-)