Bug 1627510

 - %setup -q
   %autopatch


   Simply use %autosetup


 - Add a comment explaining what the patch does or why it is needed

 - export CFLAGS=-g
   export LDFLAGS=-g


Use %set_build_flags

 - make %{?_smp_mflags} → %make_build

 - %{__make} install DESTDIR=%{buildroot} → %make_install

 - %post
   /sbin/ldconfig

   %postun
   /sbin/ldconfig

This is not necessary anymore as it has been automated with %transfiletrigger tarting F28. If you intend to support F27, add %ldconfig_scriptlets

 - Licenses files must be installed with %license, not %doc:

%files
%license COPYING  COPYING.bsd  COPYING.gplv2
%doc README.md

 - License field is incorrect, it should be:

License:	BSD or GPLv2

 - You should use %{?_isa} here:

Requires: %{name}%{?_isa} = %{version}-%{release}

 - It would be nice to patch the Makefile to use $(INSTALL) instead of install:

sed -i "s|^\tinstall -|\t\$(INSTALL) -|" Makefile

  in order to keep the timestamps.

Thanks for the review!

New version available here:

Spec URL: https://nhorman.fedorapeople.org/jitterentropy.spec
SRPM URL: https://nhorman.fedorapeople.org/jitterentropy-2.1.2-2.fc28.src.rpm

incorporating all the above changes

 The Source0 is wrong:

Source0:	%url/archive/v%{version}/%{name}-%{version}.tar.gz

also the archive in your SRPM differs from the one downloaded. 

 - Thus it should be:

%prep
%autosetup -n %{name}-library-%{version}


 - Remove trailing tabs

 - Build error:

BUILDSTDERR:     File not found: /builddir/build/BUILDROOT/jitterentropy-2.1.2-2.fc30.x86_64/usr/lib64/libjitterentropy.so.2.1.1
Child return code was: 1

   You forgot to bump the library version. Just use instead:

%files
%doc README.md
%license COPYING COPYING.bsd COPYING.gplv2
%{_libdir}/libjitterentropy.so.2*


  - In general, packagers SHOULD NOT ship static libraries.

    We want to be able to track which packages are using static libraries (so we can find which packages need to be rebuilt if a security flaw in a static library is fixed, for instance). There are two scenarios in which static libraries are packaged:

    Static libraries and shared libraries. In this case, the static libraries MUST be placed in a *-static subpackage. Separating the static libraries from the other development files in *-devel allow us to track this usage by checking which packages BuildRequire the *-static package. The intent is that whenever possible, packages will move away from using these static libraries, to the shared libraries. If the *-static subpackage requires headers or other files from *-devel in order to be useful it MUST require the *-devel subpackage.

 → i.e. if you *really* need the static library, put it in a -static subpackage

 - If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: jitterentropy-devel. Does not provide
  -static: jitterentropy-devel.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "*No copyright* BSD (3 clause)", "Unknown or
     generated", "BSD (3 clause) GPL". 8 files have unknown license.
     Detailed output of licensecheck in
     /home/bob/packaging/review/jitterentropy/review-
     jitterentropy/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     jitterentropy-debuginfo , jitterentropy-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: jitterentropy-2.1.2-2.fc30.x86_64.rpm
          jitterentropy-devel-2.1.2-2.fc30.x86_64.rpm
          jitterentropy-debuginfo-2.1.2-2.fc30.x86_64.rpm
          jitterentropy-debugsource-2.1.2-2.fc30.x86_64.rpm
          jitterentropy-2.1.2-2.fc30.src.rpm
jitterentropy.x86_64: W: spelling-error Summary(en_US) jitter -> hitter, jotter, jitters
jitterentropy.x86_64: W: spelling-error %description -l en_US jitter -> hitter, jotter, jitters
jitterentropy.src: W: spelling-error Summary(en_US) jitter -> hitter, jotter, jitters
jitterentropy.src: W: spelling-error %description -l en_US jitter -> hitter, jotter, jitters
5 packages and 0 specfiles checked; 0 errors, 4 warnings.

Thanks!  New package

Spec URL: https://nhorman.fedorapeople.org/jitterentropy.spec
SRPM URL: https://nhorman.fedorapeople.org/jitterentropy-2.1.2-2.fc28.src.rpm

incorporating all the above changes in comment 3

Sorry, incorrect paste.  correct urls are
Spec URL: https://nhorman.fedorapeople.org/jitterentropy.spec
SRPM URL: https://nhorman.fedorapeople.org/jitterentropy-2.1.2-3.fc28.src.rpm

 - Remove trailing tabs (1st line)


Package is approved. Please fix the above issue before import.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/jitterentropy

jitterentropy-2.1.2-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-33d2804809

jitterentropy-2.1.2-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f48792a983

jitterentropy-2.1.2-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f48792a983

jitterentropy-2.1.2-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-33d2804809

jitterentropy-2.1.2-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

jitterentropy-2.1.2-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.