Bug 1627897

Summary:	The controller.yaml in the multiple-nics templates are missing the external default route upon generation
Product:	Red Hat OpenStack	Reporter:	Darin Sorrentino <dsorrent>
Component:	openstack-tripleo-heat-templates	Assignee:	Emilien Macchi <emacchi>
Status:	CLOSED DUPLICATE	QA Contact:	Gurenko Alex <agurenko>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	13.0 (Queens)	CC:	aschultz, bfournie, mburns
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-19 16:45:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Darin Sorrentino 2018-09-11 19:32:05 UTC

Description of problem:

When the controller.yaml file gets generated for the multiple-nics templates, it is missing ExternalInterfaceDefaultRoute

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. mkdir /tmp/gen_templates
2. cp -pR /usr/share/openstack-tripleo-heat-templates/* /tmp/gen_templates/
3. cd /tmp/gen_templates
4. tools/process-templates.py
5. cd network/config
6. grep -r 'get_param: ExternalInterfaceDefaultRoute'


Actual results:

(undercloud) [stack@ds-osp13-uc config]$ grep -r 'get_param: ExternalInterfaceDefaultRoute'
bond-with-vlans/controller-v6.j2.yaml:                      get_param: ExternalInterfaceDefaultRoute
bond-with-vlans/controller-v6.yaml:                      get_param: ExternalInterfaceDefaultRoute
bond-with-vlans/controller.yaml:                      get_param: ExternalInterfaceDefaultRoute
multiple-nics/controller-v6.j2.yaml:                    get_param: ExternalInterfaceDefaultRoute
multiple-nics/controller-v6.yaml:                    get_param: ExternalInterfaceDefaultRoute
single-nic-linux-bridge-vlans/controller-v6.j2.yaml:                    get_param: ExternalInterfaceDefaultRoute
single-nic-linux-bridge-vlans/controller-v6.yaml:                    get_param: ExternalInterfaceDefaultRoute
single-nic-linux-bridge-vlans/controller.yaml:                    get_param: ExternalInterfaceDefaultRoute
single-nic-vlans/controller-v6.j2.yaml:                      get_param: ExternalInterfaceDefaultRoute
single-nic-vlans/controller-v6.yaml:                      get_param: ExternalInterfaceDefaultRoute
single-nic-vlans/controller.yaml:                      get_param: ExternalInterfaceDefaultRoute
(undercloud) [stack@ds-osp13-uc config]$ 



Expected results:

All of the files in controller.yaml should have a line where it's setting the external gateway.  As you can see it sets it for controller.yaml in bond-with-vlans, single-nic-linux-bridge-vlans and single-nic-vlans.   It even sets it for the controller-v6.yaml in multiple-nics, but it doesn't set it for controller.yaml in multiple-nics.

Additional info:

Comment 1 Bob Fournier 2018-09-19 16:45:06 UTC

Darin - thanks for the detailed reproduction steps.  This was fixed here -https://review.openstack.org/#/c/566403/ for bug https://bugzilla.redhat.com/show_bug.cgi?id=1594025.

The fix is available in 13z2.

Marking this as a duplicate.

*** This bug has been marked as a duplicate of bug 1594025 ***