Bug 1627999 (rust-criterion-stats)

Summary: Review Request: rust-criterion-stats - Criterion's statistics library
Product: [Fedora] Fedora Reporter: Igor Raits <igor.raits>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-28 16:11:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Igor Raits 2018-09-12 05:21:42 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-criterion-stats.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-criterion-stats-0.2.5-1.fc30.src.rpm
Description:
Criterion's statistics library.
Fedora Account System Username: ignatenkobrain

Comment 1 Robert-André Mauchin 🐧 2018-09-12 15:45:00 UTC
brp-mangle-shebangs is not happy:

+ /usr/lib/rpm/redhat/brp-mangle-shebangs
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/README.md is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/benches/bivariate_bootstrap.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/benches/bivariate_regression.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** ERROR: ./usr/share/cargo/registry/criterion-stats-0.2.5/benches/common_bench/mod.rs has shebang which doesn't start with '/' ([allow(dead_code)])
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/benches/univariate_bootstrap.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/benches/univariate_kde.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/benches/univariate_sample.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/bivariate/bootstrap.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/bivariate/mod.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/bivariate/regression.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/bivariate/resamples.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/float.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/lib.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/test.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/tuple.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/bootstrap.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/kde/kernel.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/kde/mod.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/mixed.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/mod.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/outliers/mod.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/outliers/tukey.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/percentiles.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/resamples.rs is executable but has empty or no shebang, removing executable bit
BUILDSTDERR: *** WARNING: ./usr/share/cargo/registry/criterion-stats-0.2.5/src/univariate/sample.rs is executable but has empty or no shebang, removing executable bit
Erreur de construction de RPM :
BUILDSTDERR: erreur : Mauvais statut de sortie pour /var/tmp/rpm-tmp.NnSf7N (%install)
BUILDSTDERR:     Mauvais statut de sortie pour /var/tmp/rpm-tmp.NnSf7N (%install)
Child return code was: 1
EXCEPTION: [Error()]

It seems the whole crate is marked as executable. You should patch that.

find . -type f -exec chmod 0644 "{}" \;
find . -type d -exec chmod 0755 "{}" \;

Comment 2 Igor Raits 2019-01-28 16:11:43 UTC
Let's package it later.

Nothing uses it now.