Bug 1628263
| Summary: | wifi doesnt connect from the drop down in live WS F29 Beta 1.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | sumantro <sumukher> | ||||||
| Component: | gnome-shell | Assignee: | Owen Taylor <otaylor> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 29 | CC: | alexl, awilliam, axel.sommerfeldt, bgalvani, dcbw, fgiudici, fmuellner, gmarr, john.j5live, kparal, lbrabec, lkundrak, mclasen, otaylor, pnemade, rhughes, robatino, rstrode, sandmann, thaller | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | AcceptedFreezeException AcceptedBlocker | ||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2018-10-08 17:58:24 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1517012, 1517013 | ||||||||
| Attachments: |
|
||||||||
|
Description
sumantro
2018-09-12 15:18:15 UTC
I can reproduce this on my XPS 13 (Skylake). Don't think those journal messages have anything to do with it, though. When you click "Connect", the button animates briefly, and...that's all that happens. The network list doesn't go away. It doesn't prompt you for a password. It just keeps displaying the network list. As Sumantro says, you can click Connect as many times as you like, but nothin ain't connecting to nothin. You can connect fine from the 'Wifi' panel in the Settings app, note. Proposing this as an FE issue; it won't affect wired networking, and there are a couple of workarounds we've already discovered, but it looks bad... Proposing as a final blocker: "All elements of the default panel (or equivalent) configuration in all release-blocking desktops must function correctly in typical use. " https://fedoraproject.org/wiki/Fedora_29_Final_Release_Criteria#Default_panel_functionality Can somebody provide a complete log of NetworkManager showing the issue, with level=TRACE? See hints at https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/contrib/fedora/rpm/NetworkManager.conf Created attachment 1483079 [details]
NetworkManager log
Created attachment 1483081 [details]
journalctl -b
I am too facing issues as described here. I am using T460s laptop and following components kernel-4.18.5-300.fc29.x86_64 NetworkManager-wifi-1.12.2-2.fc29.x86_64 actually I thought in my home there started some range issue from wifi router to the room in which I use wifi on laptop. After looking into f29 beta list bugs, I found this bug and would like to give confirmation that auto-connect does not happen quickly. I too then used to disable the wifi, enable it, let it try to auto-connect the desired router but it keeps failing in first few attempts. Discussed during the 2018-09-17 blocker review meeting: [1] The decision to classify this bug as an "AcceptedFreezeException" was made as this is a prominent bug in the Workstation live, and it's the natural way for people to try and use wifi, so fixing it would be desirable. [1] https://meetbot.fedoraproject.org/fedora-blocker-review/2018-09-17/f29-blocker-review.2018-09-17-16.02.txt Discussed during the 2018-09-17 blocker review meeting: [1] The decision to classify this bug as an "AcceptedBlocker" was made as it violates the following criteria: "All elements of the default panel (or equivalent) configuration in all release-blocking desktops must function correctly in typical use" [1] https://meetbot.fedoraproject.org/fedora-blocker-review/2018-09-17/f29-blocker-review.2018-09-17-16.02.txt (In reply to Lukas Brabec from comment #5) > Created attachment 1483079 [details] > NetworkManager log I don't see any connection attempt by NM, which makes me think this is a UI bug. (In reply to Adam Williamson from comment #1) > I can reproduce this on my XPS 13 (Skylake). Don't think those journal > messages have anything to do with it, though. > > When you click "Connect", the button animates briefly, and...that's all that > happens. The network list doesn't go away. It doesn't prompt you for a > password. It just keeps displaying the network list. As Sumantro says, you > can click Connect as many times as you like, but nothin ain't connecting to > nothin. Can you please run 'journalctl -f' while clicking "Connect" and check if NM gets the activation request, or it's a GUI problem? Which GUI do you use? (In reply to Beniamino Galvani from comment #10) > (In reply to Lukas Brabec from comment #5) > > Created attachment 1483079 [details] > > NetworkManager log > > I don't see any connection attempt by NM, which makes me think this is a UI > bug. > > (In reply to Adam Williamson from comment #1) > > I can reproduce this on my XPS 13 (Skylake). Don't think those journal > > messages have anything to do with it, though. > > > > When you click "Connect", the button animates briefly, and...that's all that > > happens. The network list doesn't go away. It doesn't prompt you for a > > password. It just keeps displaying the network list. As Sumantro says, you > > can click Connect as many times as you like, but nothin ain't connecting to > > nothin. > > Can you please run 'journalctl -f' while clicking "Connect" and check if NM > gets the activation request, or it's a GUI problem? Which GUI do you use? Here's the log when I click connect Sep 18 14:36:03 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:12 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:15 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:16 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:17 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:17 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:18 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:18 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:19 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:20 localhost gnome-shell[1586]: JS ERROR: Error: Expected type utf8 for Argument 'specific_object' but got type 'undefined' _connect@resource:///org/gnome/shell/ui/status/network.js:942:17 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Sep 18 14:36:22 localhost gnome-shell[1586]: Object St.Widget (0x564f14f91440), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs. Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: == Stack trace for context 0x564f132fe260 == Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #0 564f1591c920 i resource:///org/gnome/shell/ui/modalDialog.js:93 (7f47465eddc0 @ 22) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #1 7ffe09ddf800 b resource:///org/gnome/gjs/modules/_legacy.js:82 (7f47465b0b80 @ 71) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #2 564f1591c868 i resource:///org/gnome/gjs/modules/_legacy.js:39 (7f47465b08b0 @ 215) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #3 564f1591c7d8 i resource:///org/gnome/shell/ui/status/network.js:782 (7f4745fdb670 @ 409) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #4 7ffe09de0f30 b resource:///org/gnome/gjs/modules/_legacy.js:82 (7f47465b0b80 @ 71) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #5 564f1591c750 i resource:///org/gnome/shell/ui/modalDialog.js:168 (7f47465f53a0 @ 92) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #6 564f1591c6a8 i resource:///org/gnome/gjs/modules/_legacy.js:82 (7f47465b0b80 @ 71) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #7 564f1591c5e8 i self-hosted:975 (7f47465edaf0 @ 392) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #8 564f1591c560 i resource:///org/gnome/shell/ui/tweener.js:91 (7f47465ccf70 @ 37) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #9 564f1591c4c0 i resource:///org/gnome/gjs/modules/tweener/tweener.js:208 (7f47465dd790 @ 54) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #10 564f1591c3a0 i resource:///org/gnome/gjs/modules/tweener/tweener.js:342 (7f47465dd820 @ 1742) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #11 564f1591c310 i resource:///org/gnome/gjs/modules/tweener/tweener.js:355 (7f47465dd8b0 @ 100) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #12 564f1591c298 i resource:///org/gnome/gjs/modules/tweener/tweener.js:370 (7f47465dd940 @ 10) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #13 564f1591c1c8 i resource:///org/gnome/gjs/modules/signals.js:128 (7f47465c18b0 @ 386) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #14 564f1591c138 i resource:///org/gnome/shell/ui/tweener.js:207 (7f47465d9790 @ 159) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #15 564f1591c090 i resource:///org/gnome/gjs/modules/_legacy.js:82 (7f47465b0b80 @ 71) Sep 18 14:36:22 localhost org.gnome.Shell.desktop[1586]: #16 564f1591c010 i resource:///org/gnome/shell/ui/tweener.js:182 (7f47465d9700 @ 15) Sep 18 14:36:22 localhost gnome-shell[1586]: clutter_actor_destroy: assertion 'CLUTTER_IS_ACTOR (self)' failed Aha. That sure looks like a Shell bug, yes. This seems to be complaining about this line in js/ui/status/network.js: this._client.add_and_activate_connection_async(connection, this._device, accessPoints[0].path, null, null) the arg that's a problem is the third one, "accessPoints[0].path" - that var is called 'specific_object' in the function signature. It seems that's turning out to be undefined for some reason. I'm not quite 100% sure what sort of an object accessPoints[0] is, but if it's an NM.AccessPoint, then per https://valadoc.org/libnm-glib/NM.AccessPoint.html , those don't seem to have a 'path' property. I'm flailing a bit but not entirely sure how this ever worked...I'll go poke around with some live images and see if I can nail down when it broke. Ah, OK, I see - that's the *old* libnm-glib API. This line comes from the port to plain libnm (via g-i), and I think accessPoints[0] is supposed to be a NMAccessPoint: https://developer.gnome.org/libnm/stable/NMAccessPoint.html which inherits from NMObject, which *does* have a 'path' property: https://developer.gnome.org/libnm/stable/NMObject.html#NMObject--path so, that seems like it ought to be right. Not sure what the problem is. Hrmmmmm. In the libnm source, the NMObject path property has a '(skip)' annotation, which I believe means it should be left out of introspected output: https://wiki.gnome.org/Projects/GObjectIntrospection/Annotations#Symbol_visibility https://github.com/NetworkManager/NetworkManager/blob/master/libnm/nm-object.c#L1291 Also notable, there is a get_path() method which *does* seem to be intended to be available via introspection: https://github.com/NetworkManager/NetworkManager/blob/master/libnm/nm-object.c#L101-L116 so I'm inclined to try replacing those '.path' with '.get_path()' ... That doesn't explain why this suddenly stopped working, as the network.js code has been around since late 2017 and the (skip) annotation in NM dates to 2016, but...I'm gonna try it anyhow. gnome-shell-3.30.0-4.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0f35f06ae0 gnome-shell-3.30.0-4.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0f35f06ae0 gnome-shell-3.30.0-5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e8c0ea09e0 This is definitely fixed by now. |