Bug 1628318

Summary: Possible infinite hang during rebuild if physical volume greater than 16T.
Product: Red Hat Enterprise Linux 7 Reporter: Sweet Tea Dorminy <sweettea>
Component: kmod-kvdoAssignee: Sweet Tea Dorminy <sweettea>
Status: CLOSED ERRATA QA Contact: Jakub Krysl <jkrysl>
Severity: unspecified Docs Contact:
Priority: high    
Version: 7.7CC: awalsh, bubrown, jkrysl, jmagrini, jpittman, knappch, lmiksik, msakai, rhandlin, ryan.p.norwood, vdo-qe
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 6.1.1.125 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1628316
: 1630192 (view as bug list) Environment:
Last Closed: 2018-10-30 09:40:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1628316    
Bug Blocks: 1630192    

Description Sweet Tea Dorminy 2018-09-12 18:11:34 UTC 
Description of problem:
If a block map page is more than 16T into a VDO storage device, and the recovery journal has an entry for that block map page, both normal recovery and read-only rebuild will hang indefinitely due to accidental truncation of a 64 bit block number into 32 bits.

Version-Release number of selected component (if applicable):
kmod-kvdo-6.1.0.185-17

How reproducible: Moderately

Steps to Reproduce:
1. Make a >16T physical VDO.
2. Write some data, coercing the block map pages to be at the end of the volume. (I believe the default allocation policy means this happens with any write)
3.Crash and restart the machine.

Actual results:
Infinite hang during restart

Expected results:
Finite-time waiting.

Additional info:
Comment 7 Jakub Krysl 2018-09-19 16:58:55 UTC 
I was not able to reproduce it with vdo-6.1.1.125 using the reproducer in Z-stream clone - creating VDO with 180G index and crashing while randwriting data, the rebuild passed and both VDO devices started without issues.
Comment 9 errata-xmlrpc 2018-10-30 09:40:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3094