Bug 1628561

Summary:	hammer job-invocation output returns ISE on providing invalid invocation id
Product:	Red Hat Satellite	Reporter:	Roman Plevka <rplevka>
Component:	Remote Execution	Assignee:	Adam Ruzicka <aruzicka>
Status:	CLOSED ERRATA	QA Contact:	Peter Ondrejka <pondrejk>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.4	CC:	aruzicka, inecas, pcreech
Target Milestone:	6.5.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-14 12:37:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roman Plevka 2018-09-13 12:39:42 UTC

Description of problem:
when passing wrong-non-existing job-invocation id to the `output` subcommand (together with a valid host parameter), the server returns ISE (err 500) - NoMethodError: undefined method `task' for nil:NilClass

instead of a proper 404 response code

Version-Release number of selected component (if applicable):
6.4.0-21

How reproducible:
always

Steps to Reproduce:
1. have some valid host (Say: foo)
2. hammer job-invocation output --id <invalid-id> --host foo

Actual results:
internal server error returned

Expected results:
404 status codereturned from server

Additional info:

Comment 1 Adam Ruzicka 2018-09-13 12:40:42 UTC

Created redmine issue http://projects.theforeman.org/issues/24930 from this bug

Comment 4 Satellite Program 2018-09-13 14:05:36 UTC

Upstream bug assigned to aruzicka

Comment 5 Satellite Program 2018-09-13 14:05:39 UTC

Upstream bug assigned to aruzicka

Comment 6 Satellite Program 2018-09-13 16:05:31 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/24930 has been resolved.

Comment 7 Peter Ondrejka 2018-11-07 14:50:00 UTC

Verfified on Sat 6.5 snap 2

hammer job-invocation output --id 5555 --host tami-burrel
Job invocation not found by id '5555'

Comment 11 errata-xmlrpc 2019-05-14 12:37:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1222