Bug 1628694

Summary: manpage: pkt_type definition lacks 'host' and 'other' types
Product: Red Hat Enterprise Linux 7 Reporter: Tomas Dolezal <todoleza>
Component: nftablesAssignee: Phil Sutter <psutter>
Status: CLOSED ERRATA QA Contact: Jiri Peska <jpeska>
Severity: low Docs Contact:
Priority: low    
Version: 7.6CC: jpeska, nforro, psutter
Target Milestone: rcKeywords: ManPageChange
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nftables-0.8-14.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1374754
: 1628696 (view as bug list) Environment:
Last Closed: 2019-08-06 13:06:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1374754    
Bug Blocks:    

Description Tomas Dolezal 2018-09-13 17:57:23 UTC
nftables-0.8-10.el7.x86_64

nftables will present type 'host' instead of unicast, also 'other' is not documented. all 4 types including 'unicast' alias should be mentioned in pkt_type definition.

man nft(8):
       ├──────────────┼────────────────────────────────────────┤
       │pkt_type      │ Packet type: Unicast (addressed to lo‐ │
       │              │ cal host), Broadcast (to all),  Multi‐ │
       │              │ cast (to group).                       │
       └──────────────┴────────────────────────────────────────┘


+++ This bug was initially created as a clone of Bug #1374754 +++

currently the nftables tool supports the following symbols for pkt_type matches:

broadcast
multicast
unicast

with the latter being quite misleading, actually meaning 'unicast packet for this host' or PACKET_HOST, in term of kernel's define.

Other relevant symbols are advisable, e.g. at least for the pkt_type PACKET_OTHERHOST.

--- Additional comment from Phil Sutter on 2017-10-19 10:54:24 CEST ---

This was fixed by Florian:

commit 8a7f6de536408336770e352cde939f8cb09a644d
Author: Florian Westphal <fw>
Date:   Thu Oct 27 14:31:34 2016 +0200

    meta: fix pkttype name and add 'other' symbol
    
    'unicast' doesn't check for unicast packets; it checks for PACKET_HOST,
    i.e. a packet coming in for this host.
    
    A unicast address to some other machine (e.g. because nic is
    in promisc mode) will have PACKET_OTHER.
    
    So at best this is misleading, so this patch changes it
    to 'host'.  The unicast entry is retained for compat purpose.
    
    Signed-off-by: Florian Westphal <fw>
    Acked-by: Pablo Neira Ayuso <pablo>

The patch is part of v0.7 release. Since RHEL7.5 will come with v0.8, this ticket is merely TestOnly anymore.

Comment 2 Phil Sutter 2018-09-14 09:04:51 UTC
Fix sent upstream: https://marc.info/?l=netfilter-devel&m=153691562813371&w=2

Assuming this is a minor documentation issue, targeting RHEL-7.7 for this one.

Comment 8 errata-xmlrpc 2019-08-06 13:06:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2215