Bug 1628737

Summary:	Buttons not sorted in button group on Ansible Service
Product:	Red Hat CloudForms Management Engine	Reporter:	David Luong <dluong>
Component:	UI - OPS	Assignee:	Libor Pichler <lpichler>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ganesh Hubale <ghubale>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.9.4	CC:	dmetzger, ghubale, gtanzill, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	All
Whiteboard:
Fixed In Version:	5.10.0.20	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1635759 (view as bug list)		Environment:
Last Closed:	2019-02-12 16:51:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1635759

Description David Luong 2018-09-13 20:11:37 UTC

Description of problem:
A custom button group with 3 buttons in it that are sorted as shown in attached button config screenshot, but on the service the buttons aren't sorted as configured.

Version-Release number of selected component (if applicable):
5.9.4

How reproducible:
Always

Steps to Reproduce:
1.  Create button group with certain order on buttons
2.  Check in UI for order
3.

Actual results:
Order is not respected

Expected results:
Order is as configured

Additional info:

Comment 8 CFME Bot 2018-10-03 13:21:00 UTC

New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/dfcff5af0f1cc32accfb1050b398082866ff4019
commit dfcff5af0f1cc32accfb1050b398082866ff4019
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Tue Oct  2 12:38:01 2018 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Tue Oct  2 12:38:01 2018 -0400

    Merge pull request #18049 from lpichler/fix_ordering_in_custom_buttons

    Fix ordering in list of custom buttons

    (cherry picked from commit 6a9fc2a011a1f239daef26466dbb3e1a6b8e72ff)

    https://bugzilla.redhat.com/show_bug.cgi?id=1628737

 app/models/custom_button_set.rb | 2 +-
 spec/models/custom_button_set_spec.rb | 18 +-
 2 files changed, 14 insertions(+), 6 deletions(-)

Comment 14 CFME Bot 2018-10-12 16:22:04 UTC

New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/dae2099d765d92dceb996ab7ff1133f160092acb
commit dae2099d765d92dceb996ab7ff1133f160092acb
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Wed Oct 10 14:09:50 2018 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Wed Oct 10 14:09:50 2018 -0400

    Merge pull request #18060 from lpichler/order_custom_buttons_by_array_of_ids

    Order custom buttons by array of ids

    (cherry picked from commit 49956837c8143e928004beb8fce4bf4babedc081)

    https://bugzilla.redhat.com/show_bug.cgi?id=1628737

 app/models/custom_button.rb | 5 +
 app/models/custom_button_set.rb | 2 +-
 spec/models/custom_button_set_spec.rb | 10 +-
 spec/models/custom_button_spec.rb | 21 +-
 4 files changed, 31 insertions(+), 7 deletions(-)