Bug 1629121

Summary: When a button is for 'single and list' or 'list' and has a visibility expression, the button does not display in the list view even when all VMs in the list meet the expression
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Nikhil Dhandre <ndhandre>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.9.3CC: dmetzger, hkataria, lavenel, mpovolny, obarenbo, smallamp
Target Milestone: GAKeywords: ZStream
Target Release: 5.9.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1625382 Environment:
Last Closed: 2018-11-05 13:59:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1625382    
Bug Blocks:    

Comment 2 CFME Bot 2018-09-17 17:18:10 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:

https://github.com/ManageIQ/manageiq-ui-classic/commit/4d3068652f1be604d64f779b06dd88ae6e5cbc25
commit 4d3068652f1be604d64f779b06dd88ae6e5cbc25
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Sep 13 11:23:34 2018 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Sep 13 11:23:34 2018 -0400

    Merge pull request #4629 from h-kataria/custom_button_with_expression_only_for_single_entities

    Custom Buttons with expressions are only visible on summary screen
    (cherry picked from commit 3621156b0ef7cc72a99613461d10b51b14ca7349)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1629121

 app/controllers/application_controller/buttons.rb | 8 +-
 app/views/shared/buttons/_ab_advanced_form.html.haml | 43 +-
 app/views/shared/buttons/_ab_options_form.html.haml | 3 +
 spec/controllers/miq_ae_customization_controller/custom_buttons_spec.rb | 1 +
 4 files changed, 36 insertions(+), 19 deletions(-)

Comment 6 errata-xmlrpc 2018-11-05 13:59:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:3466