Bug 1629548

Summary:	Excessive logging in posix_set_parent_ctime()
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	posix	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.1	CC:	bugs, tdtiedem, vbellur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-4.1.5	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1607049	Environment:
Last Closed:	2018-09-26 14:02:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1607049
Bug Blocks:

Description Kotresh HR 2018-09-17 04:54:10 UTC

+++ This bug was initially created as a clone of Bug #1607049 +++

Description of problem:

posix_set_parent_ctime() logs an error even when consistent ctime is not enabled. This causes a flood of log messages, like:

9-bmux-posix: posix utime set mdata failed on file [Function not implemented]

11-bmux-posix: posix parent set mdata failed on file [No such file or directory]

17-bmux-posix: posix parent set mdata failed on file [File exists]

This needs to be cleaned up.

Version-Release number of selected component (if applicable):
mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-07-21 07:33:48 EDT ---

REVIEW: https://review.gluster.org/20547 (storage/posix: Avoid log flood in posix_set_parent_ctime()) posted (#1) for review on master by Vijay Bellur

--- Additional comment from Worker Ant on 2018-07-22 23:57:49 EDT ---

COMMIT: https://review.gluster.org/20547 committed in master by "Amar Tumballi" <amarts> with a commit message- storage/posix: Avoid log flood in posix_set_parent_ctime()

posix_set_parent_ctime() unconditionally logs an error if consistent
time attributes is not enabled. This log does not add any value, prints
an incorrect errno & floods the log file.

Hence nuking this log message in this patch.

Change-Id: I82a78f2f8ce5ab518f8cdf6d9086a97049712f75
fixes: bz#1607049
Signed-off-by: Vijay Bellur <vbellur>

--- Additional comment from Travis Tiedemann on 2018-09-11 16:16:11 EDT ---

How soon will a patch be available for this?

Comment 1 Worker Ant 2018-09-17 04:57:39 UTC

REVIEW: https://review.gluster.org/21185 (storage/posix: Avoid log flood in posix_set_parent_ctime()) posted (#1) for review on release-4.1 by Kotresh HR

Comment 2 Worker Ant 2018-09-21 13:06:04 UTC

COMMIT: https://review.gluster.org/21185 committed in release-4.1 by "Kotresh HR" <khiremat> with a commit message- storage/posix: Avoid log flood in posix_set_parent_ctime()

posix_set_parent_ctime() unconditionally logs an error if consistent
time attributes is not enabled. This log does not add any value, prints
an incorrect errno & floods the log file.

Hence nuking this log message in this patch.

Backport of :
> Patch: https://review.gluster.org/20547/
> Change-Id: I82a78f2f8ce5ab518f8cdf6d9086a97049712f75
> BUG: 1607049
> Signed-off-by: Vijay Bellur <vbellur>
(cherry picked from commit e0df887ba044ce92e9a2822be9261d0f712b02bd)


Change-Id: I82a78f2f8ce5ab518f8cdf6d9086a97049712f75
fixes: bz#1629548
Signed-off-by: Vijay Bellur <vbellur>

Comment 3 Shyamsundar 2018-09-26 14:02:57 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.1.5, please open a new bug report.

glusterfs-4.1.5 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-September/000113.html
[2] https://www.gluster.org/pipermail/gluster-users/