Bug 1630112

Summary:	remove "chattr +/-x" function from xfsprogs
Product:	Red Hat Enterprise Linux 7	Reporter:	xiaoli feng <xifeng>
Component:	xfsprogs	Assignee:	Eric Sandeen <esandeen>
Status:	CLOSED ERRATA	QA Contact:	Zorro Lang <zlang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.6	CC:	esandeen, jmoyer, rhandlin, xzhou, zlang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-29 20:41:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description xiaoli feng 2018-09-18 02:13:12 UTC

Description of problem:
Because of https://bugzilla.redhat.com/show_bug.cgi?id=1623150, xfs will disable per-inode DAX enablement. So after the patches for bz1623150 applied, "chattr +/-x" in xfs_io will can't work. So I file this bug to evaluate if this function will removed in RHEL-7.6 or RHEL-7.7. Maybe RHEL-7.7 is better.

Version-Release number of selected component (if applicable):
xfsprogs-4.5.0-18.el7.x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Murphy Zhou 2020-05-11 10:04:02 UTC

This may worth doing it.

Comment 3 Eric Sandeen 2020-05-15 19:49:06 UTC

Ok, yes.  The kernel will not set or query the dax flag; it knows nothing at all about it.  So I can just remove all references to +/-x from xfs_io and the manpage as well.

(I was thinking I needed to still display it and/or allow removal, but even if the flag exists on disk the kernel will not report it, so there is no way to remove it, and it's ignored in any case)

Comment 4 Eric Sandeen 2020-05-19 13:45:14 UTC

I have a fix staged for this, but I'll need a qe ack.  Would you like me to proceed?

it removes +/-x, but that will cause an fstests failure.  I sent a patch upstream to detect if a flag is not available, and skip the test.

Comment 7 Zorro Lang 2020-06-07 14:19:48 UTC

xfsprogs-4.5.0-22.el7 has removed FS_XFLAG_DAX flag. And I can't find anything about 'x' option from lsattr and chattr man-page and help output.

# xfs_io -c 'help lsattr'
# xfs_io -c 'help chattr'
# man xfs_ioh

Comment 9 errata-xmlrpc 2020-09-29 20:41:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (xfsprogs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4028