Bug 1630279

Summary:	CVE-2018-14641 kernel: a bug in ip_frag_reasm() can cause a crash in ip_do_fragment() [fedora-all]
Product:	[Fedora] Fedora	Reporter:	Vladis Dronov <vdronov>
Component:	kernel	Assignee:	Kernel Maintainer List <kernel-maint>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	high
Version:	28	CC:	airlied, bskeggs, ewk, hdegoede, ichavero, itamar, jarodwilson, jforbes, jglisse, john.j5live, jonathan, josef, jwboyer, kernel-maint, labbott, linville, mchehab, mjg59, steved
Target Milestone:	---	Keywords:	Security, SecurityTracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Release Note
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-18 12:54:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1629636

Description Vladis Dronov 2018-09-18 10:05:25 UTC

This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

Reproducers, if any, will remain confidential and never be made public, unless done so by the security team.

Comment 1 Vladis Dronov 2018-09-18 10:05:36 UTC

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1629636,1630279

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

Comment 2 Vladis Dronov 2018-09-18 10:08:24 UTC

the fix commit 5d407b071dc3 is fixing fa0f527358bd ("ip: use rb trees for IP frag queue.").

we may also want to add 70837ffe3085, another fix to fa0f527358bd, there is no security impact, but backport is trivial.

Comment 3 Justin M. Forbes 2018-09-18 12:54:23 UTC

This is the exact same thing you commented in bug 1616059.  We already showed that both of those commits are fixing bugs that only existed in 4.19-rc kernels, and never shipped to a stable distribution.

*** This bug has been marked as a duplicate of bug 1616059 ***

Comment 4 Vladis Dronov 2018-09-25 10:33:30 UTC

these bugs existed not only in 4.19-rc kernels, but in all kernels which has backported fa0f527358bd in order to fix CVE-2018-5391, i.e. in fedora-27/28 also.

now fedora-27/28 has this fix, thank you:

https://src.fedoraproject.org/cgit/rpms/kernel.git/commit/?h=f27&id=dfce0df4f20e7da1c5c707dabd658d657ee7aac5

https://src.fedoraproject.org/cgit/rpms/kernel.git/commit/?h=f28&id=0fc194c42cc120bc3f00abfe5d57450b6a29681a