Bug 1630837

Summary:	trademgen: Remove (sub)packages from Fedora 30+: python2-trademgen
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	trademgen	Assignee:	Denis Arnaud <denis.arnaud_fedora>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	cstratak, denis.arnaud_fedora, igor.raits, mhroncok, ngompa13, pviktori, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-01-17 11:04:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1625773

Description Miro Hrončok 2018-09-19 11:40:43 UTC

In line with the Mass Python 2 Package Removal [0], the following (sub)packages of trademgen were marked for removal:

 * python2-trademgen

According to our query, those (sub)packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please remove them from your package.

As said in the change document, if there is no objection in a week, we will remove the package(s) as soon as we get to it. This change might not match your packaging style, so we'd prefer if you did the change. If you need more time, please let us know here.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal

Comment 1 Miro Hrončok 2019-01-14 15:01:01 UTC

The removal is not straightforward. Denis, could you please help?

Comment 2 Denis Arnaud 2019-01-14 16:07:49 UTC

(In reply to Miro Hrončok from comment #1)
> The removal is not straightforward. Denis, could you please help?

Yes, for sure, no problem. I may be able to work on it only this weekend though. I have very similar packages where I already migrated to Python 3, so it is what I intend to here as well (as I am the owner/main maintainer of upstream as well).

Comment 3 Miro Hrončok 2019-01-14 16:18:03 UTC

Thanks!

Comment 4 Denis Arnaud 2019-01-15 22:54:34 UTC

New successful build, trademgen-1.00.3-1.fc30: https://koji.fedoraproject.org/koji/taskinfo?taskID=32051389
Featuring a new upstream release, trademgen-1.00.3.tar.gz (available from GitHub: https://github.com/airsim/trademgen/archive/trademgen-1.00.3.tar.gz)

Note, if you would like to reproduce right away, that I had to manually install the updated dependencies (e.g., stdair, sevmgr) from Koji, but those new packages should find their way to Rawhide repositories very soon now (with the nightly refresh).

'fedpkg lint' does not report any issue. But I would very welcome help on simplifying the packaging of the Python part, for instance in https://src.fedoraproject.org/rpms/trademgen/blob/master/f/trademgen.spec#_77

Comment 5 Miro Hrončok 2019-01-16 08:28:21 UTC

Thank you!

Best I could do: https://src.fedoraproject.org/rpms/trademgen/pull-request/1

Comment 6 Denis Arnaud 2019-01-16 14:42:02 UTC

(In reply to Miro Hrončok from comment #5)
> Best I could do: https://src.fedoraproject.org/rpms/trademgen/pull-request/1

That's already very good, thanks!

New build, trademgen-1.00.3-2.fc30: https://koji.fedoraproject.org/koji/taskinfo?taskID=32066751

Just an additional question from my side: in the clean-up, should we also remove lines ##7-12 in the trademgen.spec file (https://src.fedoraproject.org/rpms/trademgen/blob/master/f/trademgen.spec#_7)?