Bug 1632502

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Rpmlint
-------
Checking: python-lark-parser-0.6.4-0.fc30.noarch.rpm
          python-lark-parser-0.6.4-0.fc30.src.rpm
python-lark-parser.noarch: W: spelling-error %description -l en_US Earley -> Earle, Parley, Barley
python-lark-parser.noarch: W: spelling-error %description -l en_US interchangably -> interchangeably, interchangeable, interchangeability
python-lark-parser.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
python-lark-parser.src: W: spelling-error %description -l en_US Earley -> Earle, Parley, Barley
python-lark-parser.src: W: spelling-error %description -l en_US interchangably -> interchangeably, interchangeable, interchangeability
python-lark-parser.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
python-lark-parser.src: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
python-lark-parser.src: W: invalid-url Source0: lark-parser-0.6.4.tar.gz
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
python-lark-parser.noarch: W: spelling-error %description -l en_US Earley -> Earle, Parley, Barley
python-lark-parser.noarch: W: spelling-error %description -l en_US interchangably -> interchangeably, interchangeable, interchangeability
python-lark-parser.noarch: W: spelling-error %description -l en_US automagically -> automatically, auto magically, auto-magically
python-lark-parser.noarch: W: invalid-url URL: https://github.com/lark-parser/lark <urlopen error [Errno -2] Name or service not known>
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

%license LICENSE

remove %defattr(-,root,root,-)

%{python3_sitelib}/lark_parser-*.egg-info  <- try this

change 

%build
%py3_build

%install
%py3_install

https://fedoraproject.org/wiki/Packaging:Python

Release start in 1 no 0 please change 

fix this and I approve the package!

Regards!

Thanks for the review, I just updated the spec file.

Can you re-review it ?

Package approved!

regards!

Thanks !

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-lark-parser

python-lark-parser-0.6.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-af445bfc33

python-lark-parser-0.6.4-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb156756d4

python-lark-parser-0.6.4-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-cb156756d4

python-lark-parser-0.6.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-af445bfc33

python-lark-parser-0.6.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

python-lark-parser-0.6.4-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

There are some issues with this package, and it should probably not have been accepted as-is.

1) https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming

"A built package however must include the Python major version in the name, using the python3- prefix. This is accomplished by adding a subpackage. See example bellow."

There is no such python3-lark-parser sub-package.

2) The Group tag should not be present.

3) The package contains a test suite. It is not run in %check.

I'm CCing Miro, because he knows more about python packaging than I do - also because the package naming might cause confusion and might have to be fixed at some point.

Agreed, this is violating the Python naming guidelines. See the example specfile at:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_python_spec_file


Luis, as a sponsor, please be more careful when approving packages.

2 and 3 also makes a point.

Hi Miro --

My apologize.

--------------------------

Thomas please fix asap! 

(1)
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_python_spec_file

remove group tag (2) / enable test. (3)

Regards!

Hi Thomas --

Any update?

Cheers,

Hi,

I will do that during decembre, maybe during the second part of december.

Regards,

Hi Thomas --

Any update?

Cheers,

Hello

I just pushed the a new spec in the git. Can you tell me if it's now ok ?

I keeped disabled the tests because they are failing. But it's fully working for my usage. I have to check what is going on.
The next update (0.6.5 need js2py that is not packaged so I can't just bump the version).

Regards

Naming's OK now, thanks.

The tests are only failing because one file ("test.lark") is missing from the pypi sources.
If you include that in your package and copy it to the expeced location, the tests pass.

Also, where did you get the information that 0.6.5 now needs js2py?
I've been using 0.6.5 for some time without it, and looking at the diff from 0.6.4 to 0.6.5, there's no mention of such a change.

Hi Thomas -- Any update!

Cheers,

Hello

I was wrong, I liked this bug : https://bugzilla.redhat.com/show_bug.cgi?id=1697347

So now, everything should be ok.

Regards.