Bug 1632545
Summary: | Review Request: perl-WWW-xkcd - Synchronous and asynchronous interfaces to xkcd comics | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mike Oliver <mike> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jplesnik, package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-WWW-xkcd-0.009-1.fc30 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-07-07 17:58:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mike Oliver
2018-09-25 03:37:06 UTC
Blocking FE-NEEDSPONSOR because you're not a member of the packaging group yet. URL and Source addresses are Ok. Source archive (SHA-256: 7d7b5e151c92ad3c0edb48e508f9cb847bd06cf44403754bd0465844446a0cb2) is original. Ok. Summary verified from lib/WWW/xkcd.pm. Ok. Description verified from lib/WWW/xkcd.pm. → Use the description provided in the file: This module allows you to access xkcd comics (http://www.xkcd.com/) using the official API in synchronous mode (what people are used to) or in asynchronous mode. The asynchronous mode requires you have AnyEvent and AnyEvent::HTTP available. However, since it's just supported and not necessary, it is not declared as a prerequisite. License verified from lib/WWW/xkcd.pm and LICENSE. → The License: field is incorrect, for Perl license it should be: License: GPL+ or Artistic No XS code, noarch BuildArch is Ok. All tests pass. Ok. $ rpmlint perl-WWW-xkcd.spec review-perl-WWW-xkcd/results/perl-WWW-xkcd-0.009-1.fc30.noarch.rpm review-perl-WWW-xkcd/results/perl-WWW-xkcd-0.009-1.fc30.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpm -q -lv -p perl-WWW-xkcd-0.009-1.fc30.noarch.rpm drwxr-xr-x 2 root root 0 sept. 26 15:11 /usr/share/doc/perl-WWW-xkcd -rw-r--r-- 1 root root 1138 juil. 21 14:14 /usr/share/doc/perl-WWW-xkcd/Changes drwxr-xr-x 2 root root 0 sept. 26 15:11 /usr/share/licenses/perl-WWW-xkcd -rw-r--r-- 1 root root 18337 juil. 21 14:14 /usr/share/licenses/perl-WWW-xkcd/LICENSE -rw-r--r-- 1 root root 2587 sept. 26 15:11 /usr/share/man/man3/WWW::xkcd.3pm.gz drwxr-xr-x 2 root root 0 sept. 26 15:11 /usr/share/perl5/vendor_perl/WWW -rw-r--r-- 1 root root 6589 juil. 21 14:14 /usr/share/perl5/vendor_perl/WWW/xkcd.pm File permissions and layout are Ok. $ rpm -q --requires -p perl-WWW-xkcd-0.009-1.fc30.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.28.0) 2 perl(Carp) 2 perl(HTTP::Tiny) 2 perl(JSON::MaybeXS) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. → You don't need: Requires: perl(Carp) Requires: perl(HTTP::Tiny) Requires: perl(JSON::MaybeXS) Deps are automatically picked up. $ rpm -q --provides -p perl-WWW-xkcd-0.009-1.fc30.noarch.rpm perl(WWW::xkcd) = 0.009 perl-WWW-xkcd = 0.009-1.fc30 Binary provides are Ok. Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=29901361). Ok The package is in line with Fedora and Perl packaging guidelines. Resolution: Package NOT approved. Fix: - Use the description provided - Correct the License: field - Remove the extraneous Requires: Spec URL: https://mklvr.fedorapeople.org/fedora-packages/perl-WWW-xkcd/perl-WWW-xkcd.spec SRPM URL: https://mklvr.fedorapeople.org/fedora-packages/perl-WWW-xkcd/perl-WWW-xkcd-0.009-1.fc28.src.rpm Description: Synchronous and asynchronous interfaces to xkcd comics Fedora Account System Username: mklvr Requested changes have been made. Thanks for the review! Another point I forgot: %{__perl} and %{__make} are not really useful macros, just use perl and make. The package is approved. But you still need to find a sponsor: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group mklvr has been sponsored. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-WWW-xkcd |