Bug 1632634

Summary: Foldcolumn is not redrawn for rows above the cursors current position.
Product: [Fedora] Fedora Reporter: asmjmisc <jmisc>
Component: vimAssignee: Karsten Hopp <karsten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 28CC: gchamoul, karsten, zdohnal
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: vim-8.1.450-1.fc28 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-07 22:16:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fold column working
none
Fold column broken
none
Fold column partially redrawn none

Description asmjmisc 2018-09-25 09:32:34 UTC 
vim, when configured to display the fold column of any depth (1 or more), fails to redraw above the current cursor positions line. Also, when within a foldable section, the fold indicator is missing its starting glyph, which reappears when the cursor lands on either the opening or closing symbol of the fold.

I'm observing this on vim from vim-enhanced 2:8.1.408-1.fc28

How reproducible:
To reproduce the behavior, make sure vim was compiled with +folding (see vim --version), and set the following minimum set of options:

set foldmethod=syntax (this will enable folding for recognized filetypes based on syntax; no need for extra fold symbols)
set foldcolumn=1 (or any other legal value above 1)

After having done that, open a file that has some sort of nested structure (or recognized programming language source, containing, for example, function definitions). Open all the folds by hitting zR in sequence and scroll through the file crossing folds and observe the foldcolumn on the left.

After hitting ctrl-l (redraw) - the fold column is redrawn properly, and subsequent movements again break the column.

I'm not sure if this bug has been introduced by Fedora patches or upstream (I haven't had the time to check yet), but I'm starting here.
Comment 1 asmjmisc 2018-09-25 09:33:36 UTC 
Created attachment 1486656 [details]
Fold column working
Comment 2 asmjmisc 2018-09-25 09:34:19 UTC 
Created attachment 1486657 [details]
Fold column broken
Comment 3 asmjmisc 2018-09-25 09:35:33 UTC 
Created attachment 1486658 [details]
Fold column partially redrawn

This happens when the cursor is moved back up the file, resulting in the foldcolumn being drawn only partially, starting from the cursor line.
Comment 4 asmjmisc 2018-09-26 05:42:32 UTC 
Someone filed a bug report on vim's official GitHub issues page, describing similar behavior: https://github.com/vim/vim/issues/3484. I forgot to check, but can now confirm, that the bug manifests when the 'relativenumber' option is set.
Comment 5 Zdenek Dohnal 2018-09-26 11:13:00 UTC 
Hi,

thank you for finding it out! I'll add the upstream issue.
Comment 6 asmjmisc 2018-10-03 07:38:10 UTC 
Good news. It appears that this is now fixed upstream, in patch 8.1.0449, commit here: https://github.com/vim/vim/commit/7701f308565fdc7b5096a6597d9c3b63de0bbcec. I haven't yet verified the patch and won't be able to for another 12 hours. If anyone can fire off a build on Koji to test later, that'd be extra great. :)
Comment 7 Zdenek Dohnal 2018-10-03 08:21:33 UTC 
I'm going to build the newest upstream patchlevel today, so it will be fixed in the next vim update. Thank you again for finding it out!
Comment 8 Fedora Update System 2018-10-03 10:46:34 UTC 
vim-8.1.450-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc1c68d21a
Comment 9 Fedora Update System 2018-10-03 15:02:15 UTC 
vim-8.1.450-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc1c68d21a
Comment 10 Fedora Update System 2018-10-07 22:16:04 UTC 
vim-8.1.450-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.