Bug 1632758

Summary:	Packageis missing some BuildRequires
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <zebob.m>
Component:	golang-github-fatih-color	Assignee:	Matthias Runge <mrunge>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mrunge
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	golang-github-fatih-color-1.7.0-2.fc30 golang-github-fatih-color-1.7.0-2.fc29	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-09-26 06:44:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert-André Mauchin 🐧 2018-09-25 13:33:00 UTC

Your package is missing BuildRequires. See https://github.com/fatih/color/blob/master/Gopkg.toml

Add:

BuildRequires: golang(github.com/mattn/go-colorable)
BuildRequires: golang(github.com/mattn/go-isatty)


This is causing issue for packages depending on yours. See this build log for my package jid: https://kojipkgs.fedoraproject.org/work/tasks/6714/29846714/build.log

Also it would be great to convert your package to the new go packaging: https://fedoraproject.org/wiki/More_Go_packaging

I'll send a PR if I have the time.

Comment 1 Matthias Runge 2018-09-26 06:30:59 UTC

Thank you for the PR.

Unfortunately, only go-isatty exist as rpm yet. While they sound somewhat familiar to me, I believe missing requirements are the result of a package update.

If I have the time, I can send a review for go-colorable.

Comment 2 Matthias Runge 2018-09-26 06:32:47 UTC

Please ignore the comment1. I now see it.

Comment 3 Fedora Update System 2018-09-26 06:53:43 UTC

golang-github-fatih-color-1.7.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2a21eb682b

Comment 4 Fedora Update System 2018-09-27 16:41:45 UTC

golang-github-fatih-color-1.7.0-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2a21eb682b

Comment 5 Fedora Update System 2018-10-09 00:04:56 UTC

golang-github-fatih-color-1.7.0-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.