Bug 1633043
Summary: | CVE-2018-17075 kompose: golang-org-x-net-html: Mishandle of "in frameset" causes runtime panic in html.Parse() via crafted html [fedora-all] | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Sam Fowler <sfowler> |
Component: | kompose | Assignee: | Dusty Mabe <dustymabe> |
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 28 | CC: | charlie, dustymabe, kumarpraveen.nitdgp, sfowler |
Target Milestone: | --- | Keywords: | Security, SecurityTracking |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Release Note | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-07-11 19:34:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1633041 |
Description
Sam Fowler
2018-09-26 06:18:31 UTC
Use the following template to for the 'fedpkg update' request to submit an update for this issue as it contains the top-level parent bug(s) as well as this tracking bug. This will ensure that all associated bugs get updated when new packages are pushed to stable. ===== # bugfix, security, enhancement, newpackage (required) type=security # testing, stable request=testing # Bug numbers: 1234,9876 bugs=1633041,1633043 # Description of your update notes=Security fix for [PUT CVEs HERE] # Enable request automation based on the stable/unstable karma thresholds autokarma=True stable_karma=3 unstable_karma=-3 # Automatically close bugs when this marked as stable close_bugs=True # Suggest that users restart after update suggest_reboot=False ====== Additionally, you may opt to use the bodhi web interface to submit updates: https://bodhi.fedoraproject.org/updates/new I'm the core maintainer of Kompose. Bit confused what to do here, we don't use html.Parse anywhere within our code: https://github.com/kubernetes/kompose/search?q=html.Parse&unscoped_q=html.Parse Nor the /x/net/html library. I believe this alert is a false-positive. (In reply to charlie from comment #2) > > I believe this alert is a false-positive. If so let's close as "CLOSED NOTABUG" (In reply to charlie from comment #2) > I'm the core maintainer of Kompose. > > Bit confused what to do here, we don't use html.Parse anywhere within our > code: > > https://github.com/kubernetes/kompose/search?q=html.Parse&unscoped_q=html. > Parse > > Nor the /x/net/html library. > > I believe this alert is a false-positive. Sorry for late response. The only reason this was filed against kompose in fedora-all is the results of this query: $ dnf repoquery --whatprovides 'bundled(golang(golang.org/x/net/html))' --latest-limit 1 kompose-0:1.7.0-2.fc28.x86_64 origin-0:3.9.0-4.fc28.x86_64 (In reply to Dusty Mabe from comment #3) > (In reply to charlie from comment #2) > > > > I believe this alert is a false-positive. > > If so let's close as "CLOSED NOTABUG" Indeed, if html.Parse is not used, then I agree this can be closed as NOTABUG. Charlie, It looks like the generated spec file does actually report that we have bundled that library: https://src.fedoraproject.org/rpms/kompose/blob/master/f/kompose.spec#_433 It must be one of the vendored projects that use it. From the CVE bug (https://bugzilla.redhat.com/show_bug.cgi?id=1633041): The html package (aka x/net/html) before 2018-07-13 in Go mishandles "in frameset" insertion mode, leading to a "panic: runtime error" for html.Parse of <template><object>, <template><applet>, or <template><marquee>. This is related to HTMLTreeBuilder.cpp in WebKit. Charlie, Can we try to update our dependencies to see if we can get updated to a newer version of x/net/html that is after 2018-07-13 ? This message is a reminder that Fedora 28 is nearing its end of life. On 2019-May-28 Fedora will stop maintaining and issuing updates for Fedora 28. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '28'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 28 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. It appears this bug was missed in the EOL closure for F28 on 2019-05-28. If this bug still exists on supported versions, please reopen and update the version. If you cannot update the version, please needinfo the assignee. |