Bug 1633504

Summary:	node-problem-detector fails to install in disconnected install
Product:	OpenShift Container Platform	Reporter:	Jaspreet Kaur <jkaur>
Component:	Node	Assignee:	Joel Smith <joelsmith>
Status:	CLOSED ERRATA	QA Contact:	Weinan Liu <weinliu>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.11.0	CC:	aos-bugs, avagarwa, cshereme, jokerman, mmccomas, sgaikwad, vrutkovs, wjiang
Target Milestone:	---
Target Release:	3.11.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-01-10 09:04:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1670390

Description Jaspreet Kaur 2018-09-27 07:48:55 UTC

Description of problem: When installing node-problem-detector it fails as it tries to pull from registry.redhat.io  and doesnt consider oreg_url
 
Version-Release number of the following components:
rpm -q openshift-ansible

openshift-ansible-3.11.7-1.git.0.911481d.el7_5.noarch

rpm -q ansible
ansible-2.6.4-1.el7ae.noarch
ansible --version

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results: fails
Expected results: Should succeed without any issue.


Additional info:
https://github.com/openshift/openshift-ansible/blob/release-3.11/roles/openshift_node_problem_detector/defaults/main.yaml#L13

Comment 1 Scott Dodson 2018-09-27 12:53:58 UTC

Node problem detector needs to be updated to follow something like https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_web_console/defaults/main.yml#L7

Comment 2 Suresh 2018-09-27 16:29:31 UTC

Node-problem-detector always fails (irrespective of disconnected environment). Specifying the registry url using oreg_url doesn't help and it always tries to get the images from registry.redhat.io

Tried with "openshift_docker_additional_registries" as well which failed with the same error.

Comment 3 Suresh 2018-09-27 20:10:29 UTC

This worked for me after modifying the image parameters. Created a PR for this:

https://github.com/openshift/openshift-ansible/pull/10260

Comment 4 Avesh Agarwal 2018-09-28 15:34:06 UTC

Based on my comment https://github.com/openshift/openshift-ansible/pull/10260#issuecomment-425471968, I am moving it to 3.11.z, please let me know if you disagree. So far does not seem critical enough to hold 3.11.

Comment 5 Suresh 2018-09-28 17:36:36 UTC

If the customer tries to install Node Problem detector in 3.11 from Satellite or disconnected installations, the installations will fail. So, they either need to disable Node Problem detector or pull the images manually on the nodes. I think, since we can workaround this issue, we are good to wait till 3.11.z

Comment 6 Vadim Rutkovsky 2018-10-12 14:14:22 UTC

3.11 PR - https://github.com/openshift/openshift-ansible/pull/10335

Comment 7 Vadim Rutkovsky 2018-10-15 09:07:53 UTC

Fix is available in openshift-ansible-3.11.23-1

Comment 10 errata-xmlrpc 2019-01-10 09:04:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0024