Bug 1634602
Summary: | cryptlib: Remove (sub)packages from Fedora 30+: cryptlib-python2 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
Component: | cryptlib | Assignee: | Ralf Senderek <fedora> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | cstratak, fedora, igor.raits, mhroncok, ngompa13, pviktori, zbyszek |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | cryptlib-3.4.4-11.fc30 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-10-04 05:06:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1625773 |
Description
Miro Hrončok
2018-10-01 08:59:12 UTC
The python2 module is now removed. Python2 is still required to build the package. Thanks for the update. Please, stop adding the spec file to the lookaside cache. It is very confusing when the specfile immediately replaces itself with the older version. Also, you don't need python2-devel anymore. I wanted to send you a pull request, but pagure just says "waiting" all the time, so here are two commits on github: https://github.com/hroncok/cryptlib-spec/commit/d44b74ae55d77ef439c4a1250b2f1c679b19a458 https://github.com/hroncok/cryptlib-spec/commit/c53213e4ca3f2d77a238ca53eb7f92beb0891f66 (In reply to Miro Hrončok from comment #2) > Also, you don't need python2-devel anymore. Actually I do need python2-devel. Have a look at the source code. If I didn't I'd had it removed by now. I've looked at the source code and I don't understand why python2-devel is needed (I understand why python2 is needed). Here's the PR: https://src.fedoraproject.org/rpms/cryptlib/pull-request/2 (In reply to Miro Hrončok from comment #4) > I've looked at the source code and I don't understand why python2-devel is > needed (I understand why python2 is needed). OK, I will test it with python2-devel removed on rawhide and if it is obsolete, I'll remove that too, BUT porting the python2 scripts will take some time, it's on the to-do list. I always go for minimal changes to the original source code. And if I change anything, I'd seek approval from Peter Gutmann before heading to build something new. The code in the above pull request builds fine. Porting the script upstream to python3 would indeed be great. |