Bug 1634950

Summary: libmacaroons: Remove (sub)packages from Fedora 30+: python2-macaroons
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: libmacaroonsAssignee: Miro Hrončok <mhroncok>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: bbockelm, cstratak, igor.raits, mhroncok, ngompa13, pviktori, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libmacaroons-0.3.0-4.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-04 22:14:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1625773    

Description Miro Hrončok 2018-10-01 19:18:36 UTC
In line with the Mass Python 2 Package Removal [0], the following (sub)packages of libmacaroons were marked for removal:

 * python2-macaroons

According to our query, those (sub)packages only provide a Python 2 importable module. If this is not true, please tell us why, so we can fix our query.

Please remove them from your package.

As said in the change document, if there is no objection in a week, we will remove the package(s) as soon as we get to it. This change might not match your packaging style, so we'd prefer if you did the change. If you need more time, please let us know here.

We hope this doesn't come to you as a surprise. If you want to know our motivation for this, please read the change document [0].

[0] https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_Removal

Comment 1 Brian Bockelman 2018-10-01 20:01:20 UTC
Thanks for the helpful reminder.  Based on my available time this week, I might take you up on the offer to automatically remove things... I'd rather spend my time working with upstream to switch to Python 3.

Best of luck on the mass removal project!  Hopefully all goes smoothly!

Comment 2 Miro Hrončok 2018-10-01 20:33:53 UTC
Thanks for your support.

Generally Cython code is quite Python 3 compatible (unless you hit too much bytes vs strings issues), see also:

https://github.com/rescrv/libmacaroons/commit/9cc2f68e81665829f7e560683d5fe0e9f7d4c4fa

Naively replacing python2 with python3 resulted in https://github.com/rescrv/libmacaroons/issues/45 for me.

Comment 3 Miro Hrončok 2019-01-15 11:09:51 UTC
Brian, shall I just remove the subpackage?

Comment 4 Miro Hrončok 2019-02-26 12:26:44 UTC
The beta freeze is at 2019-03-05. If you don't do it by then I will remove the package ~1 day before the freeze.

Comment 5 Miro Hrončok 2019-03-04 16:10:18 UTC
I'm doing this today.

Comment 6 Miro Hrončok 2019-03-04 22:13:02 UTC
Built. Not sure whether it will go directly to f31 or whether it will need bodhi, so keeping this ON_QA.

Comment 7 Miro Hrončok 2019-03-04 22:14:18 UTC
Tags:	f30

Comment 8 Red Hat Bugzilla 2023-09-14 04:39:17 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days