Bug 1635312

Summary:	Review Request: elementary-greeter - LightDM Login Screen for the elementary desktop
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-02 20:43:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1512217

Description Fabio Valentini 2018-10-02 15:10:27 UTC

This is a Review Request for =renaming= a package (from pantheon-greeter).

Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-greeter.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/elementary-greeter-3.3.0-1.fc28.src.rpm

Description: The elementary Greeter is a styled Login Screen for LightDM.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=30012386


This package will succeed the pantheon-greeter package. The last version of pantheon-greeter on rawhide was 3.2.0-6, so this package will obsolete pantheon-greeter < 3.2.0-7. I will build it for fedora 29+.

Please verify that the Provides and Obsoletes are correct for the "renamed package" scenario.

Comment 1 Neal Gompa 2018-10-02 18:36:01 UTC

Review notes:

* Package complies with Fedora Packaging Guidelines
* Package is named correctly
* Packaging is functionally identical to previous pantheon-greeter
* Obsoletes and Provides are correct

PACKAGE APPROVED.

Comment 2 Fabio Valentini 2018-10-02 19:21:55 UTC

Thanks for the quick review!

Repository and branches for master and f29 have been requested:

https://pagure.io/releng/fedora-scm-requests/issue/8393
https://pagure.io/releng/fedora-scm-requests/issue/8394

Comment 3 Gwyn Ciesla 2018-10-02 19:33:21 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/elementary-greeter

Comment 4 Fabio Valentini 2018-10-02 20:43:52 UTC

Built for rawhide/f30 and f29, and pantheon-greeter is now retired for f30+.

https://koji.fedoraproject.org/koji/buildinfo?buildID=1149389