Bug 1635480

+++ This bug was initially created as a clone of Bug #1635100 +++

Description of problem:
Use “gluster volume status volume_name –detail” each 15s in our product to check glusterfsd process status that will cause glusterd memory increase continues.

For 20 days, the memory is 6%, in the beginning, it is just 0.9%, from statedump, the glusterd will increase about 3M a day.

  USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND

root      2078  0.4  6.2 662084 128564 ?       Ssl  Sep11 124:01 /usr/sbin/glusterd –vol

 

Could you check my patch ? I already test it, the glusterd memory leak stop increase and keep memory occupy around of that value for 12 hours.

 

root      2132  0.3  1.2 662080 25152 ?        Ssl  16:05   0:24 /usr/sbin/glusterd --volfile=/opt/nokia/libexec/StorageUtils/etc/glusterd/glusterd.vol -p /run/glusterd.pid

root      2132  0.3  1.2 662080 25152 ?        Ssl  Oct01   3:00 /usr/sbin/glusterd --volfile=/opt/nokia/libexec/StorageUtils/etc/glusterd/glusterd.vol -p /run/glusterd.pid

root      2132  0.3  1.2 662080 25140 ?        Ssl  Oct01   3:05 /usr/sbin/glusterd --volfile=/opt/nokia/libexec/StorageUtils/etc/glusterd/glusterd.vol -p /run/glusterd.pid

root cause:

In the gluster v status process ,The cli response is allocated by glusterd and should be freed by cli, but cli do not free it, so glusterd memory will keep increased.

gf_cli_status_cbk

--- a/cli/src/cli-rpc-ops.c

+++ b/cli/src/cli-rpc-ops.c

@@ -8436,6 +8436,7 @@

         ret = rsp.op_ret;


 out:

+        FREE(rsp.dict.dict_val);

         if (dict)

                 dict_unref (dict);

         GF_FREE (status.brick);

--- Additional comment from Atin Mukherjee on 2018-10-02 09:35:05 EDT ---

upstream patch : https://review.gluster.org/#/c/21316/