Bug 1635617

Summary: Not user-friendly message is appears during creating cloud "flat" network if Physical Network is already in use
Product: Red Hat CloudForms Management Engine Reporter: Danylo Kholodov <dkholodo>
Component: UI - OPSAssignee: Alexander Demicev <ademicev>
Status: CLOSED CURRENTRELEASE QA Contact: Danylo Kholodov <dkholodo>
Severity: low Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: low    
Version: 5.10.0CC: ademicev, dmetzger, hkataria, lavenel, mpovolny, obarenbo, ohochman, simaishi
Target Milestone: GA   
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.20 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-12 16:51:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Embargoed:
Attachments:
Description Flags
flat_network_error_message none

Description Danylo Kholodov 2018-10-03 11:46:32 UTC
Created attachment 1489956 [details]
flat_network_error_message

Description of problem:
Not user-friendly message is appears during creating cloud "flat" network if Physical Network is already in use

Version-Release number of selected component (if applicable):
CFME 5.10.0.17 + OSP 14

How reproducible:
Always

Steps to Reproduce:
1. Login to the Cloudforms UI	
2. Navigate to Networks -> Networks	
3. Click configuration -> Add a new cloud network	
4. Select:
- Network Manager: Cloud provider
- Cloud Tenant: admin
- Provider Network Type: Flat
- Physical Network: (at a controller node execute the command: sudo docker exec -it neutron_api cat /etc/neutron/plugins/ml2/ml2_conf.ini | grep ^flat_networks)
- Network: test 
- Administrative State: Up	
5. Click add	Cloud Network "<Network Name>" created
6. Click configuration -> Add a new cloud network	
7. Select:
- Network Manager: Cloud provider
- Cloud Tenant: admin
- Provider Network Type: Flat
- Physical Network: (at a controller node execute the command: sudo docker exec -it neutron_api cat /etc/neutron/plugins/ml2/ml2_conf.ini | grep ^flat_networks)
- Network: my_flat_network
- Administrative State: Up	
8. Click add

Actual results:
Unable to create Cloud Network "my_flat_network": {"NeutronError": {"message": "Unable to create the flat network. Physical network datacentre is in use.", "type": "FlatNetworkInUse", "detail": ""}}

Expected results:
Unable to create Cloud Network "my_flat_network": Physical network "datacentre" is in use

Comment 3 CFME Bot 2018-10-15 17:12:22 UTC
New commit detected on ManageIQ/manageiq-providers-openstack/hammer:

https://github.com/ManageIQ/manageiq-providers-openstack/commit/a54e587bbf1b7754406763deab010be96e8a5048
commit a54e587bbf1b7754406763deab010be96e8a5048
Author:     Samuel Lucidi <mansam.edu>
AuthorDate: Mon Oct  8 17:12:09 2018 -0400
Commit:     Samuel Lucidi <mansam.edu>
CommitDate: Mon Oct  8 17:12:09 2018 -0400

    Merge pull request #370 from alexander-demichev/physical-network-error

    Format error when physical network is in use

    (cherry picked from commit 4586a355b8bbc83d0d99554035a0004c4dc10ab3)

    https://bugzilla.redhat.com/show_bug.cgi?id=1635617

 app/models/manageiq/providers/openstack/network_manager/cloud_network.rb | 2 +
 1 file changed, 2 insertions(+)

Comment 4 Danylo Kholodov 2018-10-25 08:34:58 UTC
Verified at the CFME 5.10.0.20