Bug 1635939

Summary:	[ansible e2e] fstab entry for a XFS bricks created on VDO volume, should have additional mount option
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	SATHEESARAN <sasundar>
Component:	rhhi	Assignee:	Sahina Bose <sabose>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	high	Docs Contact:
Priority:	high
Version:	rhhiv-1.5	CC:	rhs-bugs, sabose, sankarshan, sasundar, surs
Target Milestone:	---
Target Release:	RHHI-V 1.5
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	gluster-ansible-roles-1.0.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1635938	Environment:
Last Closed:	2019-05-20 04:55:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1635938
Bug Blocks:	1520836

Description SATHEESARAN 2018-10-04 02:28:33 UTC

Description of problem:
-----------------------
Kernel Filesystem service is started ahead of VDO service. To enable VDO service to start ahead, there is a special mount option - 'x-systemd.requires=vdo.service' - that needs to be added to the XFS fstab entry.

Example:
/dev/gluster_vg_sdc/gluster_lv_engine /gluster_bricks/engine xfs inode64,noatime,nodiratime,x-systemd.requires=vdo.service 0 0

But the gluster-ansible role is not adding this special mount option to fstab entry, if VDO is enabled

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
gluster-ansible-role-1.0

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Create a playbook that enabled VDO volumes & creates bricks up on that.
2. Observe the /etc/fstab

Actual results:
---------------
fstab entry doesn't have the special mount option - 'x-systemd.requires=vdo.service', and this leads to reboot of hosts going to maintenance shell as the filesystems are not available

Expected results:
-----------------
If XFS bricks are created on the VDO volume, fstab entry should have additional mount option - 'x-systemd.requires=vdo.service'

Comment 1 Sachidananda Urs 2018-10-04 08:24:41 UTC

Patch: https://github.com/gluster/gluster-ansible-infra/commit/db8fc7 should fix the issue.

Comment 5 SATHEESARAN 2018-10-12 13:14:41 UTC

The dependent gluster-ansible bug is already in MODIFIED state, changing the state of this bug accordingly

Comment 6 SATHEESARAN 2018-10-16 02:44:35 UTC

The dependent bug is already in ON_QA state, changing the state of this bug too

Comment 7 SATHEESARAN 2018-10-16 02:44:55 UTC

Tested with gluster-ansible-role-1.0.3

When XFS filesystem created over VDO volume, fstab entry is added with the required options

/dev/gluster_vg_sdc/gluster_lv_data /gluster_bricks/data xfs inode64,noatime,nodiratime,x-systemd.requires=vdo.service 0 0
/dev/gluster_vg_sdc/gluster_lv_vmstore /gluster_bricks/vmstore xfs inode64,noatime,nodiratime,x-systemd.requires=vdo.service 0 0
/dev/gluster_vg_sdc/gluster_lv_engine /gluster_bricks/engine xfs inode64,noatime,nodiratime,x-systemd.requires=vdo.service 0 0